GNOME Bugzilla – Bug 772510
Problems with commit messages
Last modified: 2016-10-09 11:51:56 UTC
Damned Lies generates commits like this: > Updated Italian translation (cherry picked from commit 0bfe7a678d58b6e5be40fb42a1b148aa44672bad) There are two problems: 1. Commit titles should not exceed 72 characters. See for example the GTK+ guidelines: https://git.gnome.org/browse/gtk+/tree/README.commits 2. Instead of "Updated" it should be "Update". In Git a commit title generally describes the action, not the action already done.
It's a bit unfortunate that `git cherry-pick -x <commit>` is appending to the first line of the message. Then I'll probably have to read the message and amend it with -m, as I think the fact that the commit is a cherry pick is a useful information, isn't it?
Oh... apparently modern versions of Git do add the "cherry picked..." message on the 3rd line and no longer appended to the first line. That's an other reason to update the current l10n.gnome.server from its current 12.04 Ubuntu version! So I will fix 2., but not 1. Sorry, you'll have to poke sysadmins to have a more up-to-date Git version on our server.
2. is now fixed.
Ok thanks!
(In reply to Claude Paroz from comment #3) > 2. is now fixed. I also see commits like this: Added Croatian translation I don't know if it is also fixed (Added -> Add). Do you have a link to the git commit?
Ok I see that it should be fixed: https://git.gnome.org/browse/damned-lies/commit/?id=ad7603c09911698808dec99af49696c42eaf6e0f Sorry for the noise.