After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772487 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks: 772263
 
 
Reported: 2016-10-05 23:50 UTC by Piotr Drąg
Modified: 2016-10-18 09:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (11.02 KB, patch)
2016-10-05 23:50 UTC, Piotr Drąg
none Details | Review

Description Piotr Drąg 2016-10-05 23:50:52 UTC
Created attachment 337018 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Stef Walter 2016-10-06 07:54:22 UTC
Since error messages are used in logs, on the console, I'm hesitant to just commit changes to complicate error messages further.

Are similar changes going into GLib? If so, then could you link to them ... if not, then why not?
Comment 2 Piotr Drąg 2016-10-06 16:12:29 UTC
Similar patch to GLib has been accepted: https://bugzilla.gnome.org/show_bug.cgi?id=772221

I don't know of any problems related to UTF-8 and logging.
Comment 3 Stef Walter 2016-10-18 09:37:03 UTC
Attachment 337018 [details] pushed as a14b92b - Use Unicode in translatable strings

Thanks. Merged everything except for command-line only cases. In those cases
I would prefer to stick with the simpler ASCII characters for the C locale.