After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772463 - [review] rename keyfile settings plugin functions/types [th/keyfile-rename-bgo772463]
[review] rename keyfile settings plugin functions/types [th/keyfile-rename-bg...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-05 16:49 UTC by Thomas Haller
Modified: 2016-10-06 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-10-05 16:49:34 UTC 
- all names in a header file should have an NM prefix (also for internal 
  headers).
- stuff related to keyfile settings plugin should have a common name prefix as 
  well
- names exposed by a .h file and implemented in a .c file should have a name that
  matches the file name.
  E.g. no "nm_keyfile_plugin_write_connection()" in "writer.h"


Make up a new name prefix "NMS" for settings plugins and rename keyfile settings plugin related stuff have a "NMS_KF" prefix.

Yes, NMSKfPlugin looks not nice, but  If you have a clearer suggestions, let it hear.
Comment 1 Francesco Giudici 2016-10-06 13:08:52 UTC 
lgtm.
I would anyway prefer the naming alternative you proposed: NMSKeyfile* and nms_keyfile_*
Comment 2 Thomas Haller 2016-10-06 13:24:39 UTC 
Changed to NMSKeyfile/nms_keyfile_.
Comment 3 Beniamino Galvani 2016-10-06 15:31:49 UTC 
I think that short non-namespaced file names for plugins were ok - even if the plugin is built-in, all the functions/type names are local to the plugin. But either way is fine for me.
Comment 4 Thomas Haller 2016-10-06 16:25:03 UTC 
I like the consistency about using the word "keyfile"

 - directory src/settings/plugins/keyfile
 - name of the plugin in NetworkManger.conf


(branch still waiting for ACKs...)