After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772417 - Memory leaks caused by generic fields
Memory leaks caused by generic fields
Product: libgee
Classification: Platform
Component: general
git master
Other All
: Normal critical
: ---
Assigned To: libgee-maint
Depends on:
Reported: 2016-10-04 17:07 UTC by Ole André Vadla Ravnås
Modified: 2017-01-29 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Fix generic field initialization to avoid memory leaks (3.68 KB, patch)
2016-10-04 17:07 UTC, Ole André Vadla Ravnås
committed Details | Review

Description Ole André Vadla Ravnås 2016-10-04 17:07:53 UTC
Created attachment 336910 [details] [review]
Fix generic field initialization to avoid memory leaks

Discussed this briefly with upstream on IRC, and it was concluded that this should probably have been forbidden by the Vala compiler in the first place.
Comment 1 Maciej (Matthew) Piechotka 2016-10-05 16:56:32 UTC
Sorry - I haven't look into details of patch yet but would it be possible to move to constructors instead of construct?
Comment 2 Rico Tzschichholz 2016-10-05 19:03:20 UTC
For reference
Comment 3 Rico Tzschichholz 2017-01-29 21:26:34 UTC
@Maciej: Putting the initializers in construct should be the preferred way for GObject classes where you can rely on its bottom-up init sequence.