Created attachment 336907 [details] [review]
clutter-script: Document support for top-level arrays

Despite being a widely-used feature, it doesn’t seem to be obvious from
the documentation that the top-level node in a ClutterScript JSON file
can be an object, or an array of objects. Try to clarify that in the
documentation.

Ping for review?

Review of attachment 336907 [details] [review]:

::: clutter/clutter-script.c
@@ +74,3 @@
+ * Multiple objects can be defined using an array:
+ *
+ * <informalexample><programlisting><![CDATA[

Shouldn't this XML be replaced by:

    |[<!-- language="plain" -->
    ...
    ]|

?

(In reply to Emmanuele Bassi (:ebassi) from comment #3)
> Review of attachment 336907 [details] [review] [review]:
> 
> ::: clutter/clutter-script.c
> @@ +74,3 @@
> + * Multiple objects can be defined using an array:
> + *
> + * <informalexample><programlisting><![CDATA[
> 
> Shouldn't this XML be replaced by:
> 
>     |[<!-- language="plain" -->
>     ...
>     ]|
> 
> ?

Ideally, yes. I went with <informalexample> because that’s what the rest of the file uses, but I can switch to the new syntax before pushing if you want?

Any other issues?

(In reply to Philip Withnall from comment #4)
> (In reply to Emmanuele Bassi (:ebassi) from comment #3)
> > Review of attachment 336907 [details] [review] [review] [review]:
> > 
> > ::: clutter/clutter-script.c
> > @@ +74,3 @@
> > + * Multiple objects can be defined using an array:
> > + *
> > + * <informalexample><programlisting><![CDATA[
> > 
> > Shouldn't this XML be replaced by:
> > 
> >     |[<!-- language="plain" -->
> >     ...
> >     ]|
> > 
> > ?
> 
> Ideally, yes. I went with <informalexample> because that’s what the rest of
> the file uses, but I can switch to the new syntax before pushing if you want?

That would be great.

> Any other issues?

Nope, with that fixed it's ACK-by: me.

Pushed with that change, thanks. :-)

Attachment 336907 [details] pushed as c05dc54 - clutter-script: Document support for top-level arrays