GNOME Bugzilla – Bug 772407
smart bookmarks are no longer working
Last modified: 2016-10-31 22:03:23 UTC
I just built Epiphany from master to try out some of the recent UI changes. Unfortunately my existing smart bookmarks didn't work: when I typed text into the address bar, I didn't see a dropdown list with smart bookmarks listed below. https://help.gnome.org/users/epiphany/stable/bookmark-smart.html.en
I'm not sure when I'll be able to work on this, but I'll try to do it soon. Since it has to be reimplemented from scratch, hopefully I will take the time to do it properly: as a search engine configuration preferences dialog, completely separate from the bookmarks subsystem.
(In reply to Michael Catanzaro from comment #1) > I'm not sure when I'll be able to work on this, but I'll try to do it soon. FYI: I'm more than halfway done but it needs another weekend or two, will try to finish it soon.
(In reply to Michael Catanzaro from comment #2) > FYI: I'm more than halfway done but it needs another weekend or two, will > try to finish it soon. It went faster than expected. (In reply to Michael Catanzaro from comment #1) > Since it has to be reimplemented from scratch, hopefully I will take the > time to do it properly: as a search engine configuration preferences dialog, > completely separate from the bookmarks subsystem. This is still pending. I think it's very important to make smart bookmarks actually accessible, especially since creating a smart bookmark is much tricker now than it used to be (as there's no way to set an arbitrary URL until after the bookmark is already created). But it can be a separate bug.
The following fixes have been pushed: 4350e43 Refresh completion model actions if smart bookmark changes 7ca661d Filter smart bookmarks out of bookmarks popover 25a9993 Restore smart bookmarks
Created attachment 338861 [details] [review] Refresh completion model actions if smart bookmark changes
Created attachment 338862 [details] [review] Filter smart bookmarks out of bookmarks popover
Created attachment 338863 [details] [review] Restore smart bookmarks It works exactly the same as before. If the bookmark includes %s, add it to the completion model.
(In reply to Michael Catanzaro from comment #1) > Since it has to be reimplemented from scratch, hopefully I will take the > time to do it properly: as a search engine configuration preferences dialog, > completely separate from the bookmarks subsystem. Actually I only want the dialog now. Turns out using the bookmarks subsystem for this is way easier than adding one more thing that needs to be synced, stolen into incognito mode, etc.