After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772377 - thumb_app_set_error_handles and refcounting
thumb_app_set_error_handles and refcounting
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Thumbnailer
3.22.x
Other Linux
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-03 20:07 UTC by denniswbb
Modified: 2016-10-03 21:49 UTC
See Also:
GNOME target: ---
GNOME version: 3.23/3.24


Description denniswbb 2016-10-03 20:07:11 UTC 
gst_element_get_bus is [transfer-full] so that a simple
g_object_unref(bus) in line 239 of totem-video-thumbnailer.c will really cleanup all gstreamer objects.

I found this out by reusing (privately) the code for thumbnail generation inside a single process for multiple files. After a certain number of video files, no further instances of the GStreamer object can be created as the old ones are kept in memory. Adding aforementioned patch clears this issue.
Comment 1 Bastien Nocera 2016-10-03 21:49:36 UTC 
Fixed in gnome-3-20 and master, thanks!

commit 66d30104807056d0ac1f1173ecd5e365159d2fee
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Oct 3 23:46:55 2016 +0200

    thumbnailer: Fix memory leak
    
    Spotted by denniswbb@web.de
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772377