GNOME Bugzilla – Bug 772373
Take advantage of Unicode
Last modified: 2016-10-10 10:43:59 UTC
Created attachment 336830 [details] [review] Use Unicode in translatable strings Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Review of attachment 336830 [details] [review]: A lot of these changes seem to be converting Unicode single quotation marks (‘’) into double quotation marks (“”). Please don’t do that — we explicitly chose single quotation marks because they’re less intrusive than double ones. Also, they’re Unicode already! There are a few locations where this patch correctly converts ASCII quotation marks. Could you please resubmit just those changes, and convert them to Unicode single quotation marks for consistency? Thanks. I appreciate your attention to detail. :-)
Created attachment 336943 [details] [review] Use Unicode in translatable strings While I don't agree with your decision (double quotation marks are the standard in English writing, and the rest of GNOME follows that), you are the maintainer!
(In reply to Piotr Drąg from comment #2) > Created attachment 336943 [details] [review] [review] > Use Unicode in translatable strings > > (double quotation marks are the > standard in English writing, and the rest of GNOME follows that) Depends which style guide you consult. Like most things with writing, there is no concrete consensus!
Review of attachment 336943 [details] [review]: That’s great, thanks. Please push it.
Comment on attachment 336943 [details] [review] Use Unicode in translatable strings Pushed, thanks.