After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772352 - Current overview design is different from mockup
Current overview design is different from mockup
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Overview
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-03 00:50 UTC by Estêvão Samuel Procópio Amaral
Modified: 2016-10-04 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] resources: Fix for overview design to match mockup (1.88 KB, patch)
2016-10-03 00:50 UTC, Estêvão Samuel Procópio Amaral 		committed Details | Review
[ScreenShot] Overview after patch (96.16 KB, image/png)
2016-10-03 00:52 UTC, Estêvão Samuel Procópio Amaral 		  Details

Description Estêvão Samuel Procópio Amaral 2016-10-03 00:50:14 UTC 
Created attachment 336789 [details] [review]
[PATCH] resources: Fix for overview design to match mockup

The current overview design is different from the mockup defined by the Design Team at https://github.com/gnome-design-team/gnome-mockups-lfs/blob/master/web/web-318.svg.
Comment 1 Estêvão Samuel Procópio Amaral 2016-10-03 00:52:40 UTC 
Created attachment 336790 [details]
[ScreenShot] Overview after patch

How the overview will look after applying the patch.
Comment 2 Jakub Steiner 2016-10-03 12:40:26 UTC 
Looks good, although ideally I wish we did some responsive layout depending on the available horizontal screen estate (ala Software).
Comment 3 Michael Catanzaro 2016-10-04 13:10:15 UTC 
Review of attachment 336789 [details] [review]:

OK. Do you have a GNOME git account, or do you need me to commit it?
Comment 4 Michael Catanzaro 2016-10-04 13:10:26 UTC 
(In reply to Jakub Steiner from comment #2)
> Looks good, although ideally I wish we did some responsive layout depending
> on the available horizontal screen estate (ala Software).

OK. I don't know how to do this, though, and it can be done in a different bug report.
Comment 5 Michael Catanzaro 2016-10-04 13:12:44 UTC 
(In reply to Jakub Steiner from comment #2)
> Looks good, although ideally I wish we did some responsive layout depending
> on the available horizontal screen estate (ala Software).

By the way, in master or unreleased 3.22.1 we handle overflow much better, thanks to a suggestion by Adrian.
Comment 6 Estêvão Samuel Procópio Amaral 2016-10-04 16:57:58 UTC 
No, I don't have a GNOME git account. Thanks.
Comment 7 Michael Catanzaro 2016-10-04 17:35:29 UTC 
Hi, can you attach a git formatted patch using the 'git format-patch' command, so it can be committed? Thanks.
Comment 8 Michael Catanzaro 2016-10-04 17:44:41 UTC 
Er, it is already a git formatted patch... not sure why I had trouble applying it when I tried 10 minutes ago.