GNOME Bugzilla – Bug 772348
placesviewrow: busy_spinner when visible offsets the rest of the widgets on the row
Last modified: 2016-10-10 21:57:18 UTC
This is a counterpart for https://bugzilla.gnome.org/show_bug.cgi?id=772345 and the earlier report https://bugzilla.gnome.org/show_bug.cgi?id=771161 to which (because it was still open) I've uploaded patches for the Nautilus versions of the gtkplacesview* widgets. Please see those bugs for the background info.
Created attachment 336785 [details] [review] gtkplacesviewrow: stop busy_spinner from offsetting the other widgets when visible ...by putting it in a stack. The busy_spinner and eject_button are mutually exclusive, but only the latter was coded to ensure that its visibility did not cause the rest of the row to reflow. By putting both widgets in a stack and setting child_visible on that, the row allocates enough space to show one - or none - at once, avoiding any misalignment.
Created attachment 336786 [details] [review] gtkplacesviewrow: stop busy_spinner from offsetting the other widgets when visible This time, I'll upload the right patch.
Created attachment 336953 [details] [review] gtkplacesviewrow: stop busy_spinner from offsetting the other widgets when visible Fix the <packing> position too.
Created attachment 336954 [details] screencast with patch applied, showing busy/eject/none working as expected
Attachment 336953 [details] pushed as fe6030a - gtkplacesviewrow: stop busy_spinner from offsetting the other widgets when visible
Thanks Matthias! Glad my patch helped.