After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772296 - Fix build errors/warnings
Fix build errors/warnings
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-01 16:32 UTC by Ernestas Kulik
Modified: 2016-10-06 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
debug: include gxps-version.h for GXPS_VAR (694 bytes, patch)
2016-10-01 16:32 UTC, Ernestas Kulik 		none Details | Review
path: do not return from print_token() (713 bytes, patch)
2016-10-01 16:32 UTC, Ernestas Kulik 		committed Details | Review
debug: include gxps-version.h for GXPS_VAR (694 bytes, patch)
2016-10-03 16:15 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2016-10-01 16:32:03 UTC 
master does not build for me (using Clang). Attaching a fix for that and a warning.
Comment 1 Ernestas Kulik 2016-10-01 16:32:07 UTC 
Created attachment 336730 [details] [review]
debug: include gxps-version.h for GXPS_VAR

GXPS_VAR is defined in gxps-version.h, which is not being included,
resulting in build failure.
Comment 2 Ernestas Kulik 2016-10-01 16:32:13 UTC 
Created attachment 336731 [details] [review]
path: do not return from print_token()

print_token() should not return a value, but does.
Comment 3 Carlos Garcia Campos 2016-10-03 15:35:17 UTC 
Review of attachment 336730 [details] [review]:

Thanks

::: libgxps/gxps-debug.h
@@ +22,3 @@
 #include <glib.h>
 
+#include <gxps-version.h>

This header is not installed, so better use "gxps-version.h" instead.
Comment 4 Carlos Garcia Campos 2016-10-03 15:35:38 UTC 
Review of attachment 336731 [details] [review]:

oops, thanks!
Comment 5 Ernestas Kulik 2016-10-03 16:15:13 UTC 
Created attachment 336824 [details] [review]
debug: include gxps-version.h for GXPS_VAR

GXPS_VAR is defined in gxps-version.h, which is not being included,
resulting in build failure.
Comment 6 Ernestas Kulik 2016-10-03 16:18:57 UTC 
(In reply to Carlos Garcia Campos from comment #3)
> This header is not installed, so better use "gxps-version.h" instead.

My rationale for that was that the header is generated and not placed in the same directory where the including file resides. But I will not argue, as it works all the same. :)
Comment 7 Ernestas Kulik 2016-10-06 17:19:41 UTC 
Attachment 336731 [details] pushed as 95decf1 - path: do not return from print_token()
Attachment 336824 [details] pushed as 72e8737 - debug: include gxps-version.h for GXPS_VAR