After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772295 - Streamline authentication code
Streamline authentication code
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: web-sharing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on: 769790
Blocks:
 
 
Reported: 2016-10-01 14:26 UTC by Jens Georg
Modified: 2016-10-01 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Introduce common class for WebKit authenticator (15.72 KB, patch)
2016-10-01 21:28 UTC, Jens Georg
committed Details | Review

Description Jens Georg 2016-10-01 14:26:05 UTC
WebAuthenticationPane seems to exist at least twice with similar implementation for Google and Facebook
Comment 1 Jens Georg 2016-10-01 14:27:26 UTC
Somewhat related to Bug 769790
Comment 2 Jens Georg 2016-10-01 21:28:34 UTC
Created attachment 336737 [details] [review]
Introduce common class for WebKit authenticator

This was implemented/copied three times...

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 3 Jens Georg 2016-10-01 21:29:03 UTC
Attachment 336737 [details] pushed as 71f3951 - Introduce common class for WebKit authenticator