After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772277 - Wrong sorting of bookmarks
Wrong sorting of bookmarks
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.21.x
Other Linux
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-01 01:37 UTC by Nicolas Maia
Modified: 2016-10-03 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (119.27 KB, image/png)
2016-10-01 01:37 UTC, Nicolas Maia 		  Details
shell: Sort bookmarks by page number instead of title (941 bytes, patch)
2016-10-01 11:03 UTC, Felipe Borges 		committed Details | Review

Description Nicolas Maia 2016-10-01 01:37:27 UTC 
Created attachment 336717 [details]
Screenshot

Numbered bookmarks are incorrectly sorted.

Please see the screenshot.
Comment 1 Felipe Borges 2016-10-01 11:03:28 UTC 
Created attachment 336722 [details] [review]
shell: Sort bookmarks by page number instead of title

Bookmarks shouldn't be sorted by their titles but their page
numbers. Often titles don't have any sorting text, causing
strcmp to wrongly sort them alphanumerically, just like in the
bug referenced below.
Comment 2 Felipe Borges 2016-10-01 11:35:54 UTC 
Unless we want to sort the bookmarks alphabetically instead, in that case, we should go for something like Bug 770695, with natural sorting.
Comment 3 Carlos Garcia Campos 2016-10-03 15:36:49 UTC 
Comment on attachment 336722 [details] [review]
shell: Sort bookmarks by page number instead of title

It makes sense, thanks!
Comment 4 Felipe Borges 2016-10-03 15:45:07 UTC 
Attachment 336722 [details] pushed as fa19890 - shell: Sort bookmarks by page number instead of title