GNOME Bugzilla – Bug 772268
Bookmarks properties dialog not accessible on touchscreens from popover
Last modified: 2018-01-29 15:44:14 UTC
The gear button that opens the dialog is only displayed in the popover when hovering over a bookmark. Hovering is not possible on touchscreens.
Created attachment 367516 [details] [review] Set opacity of properties button to 1 Always set opacity of properties button to 1. This makes him always visible and present. Note: Otherwise a touchscreen user wouldn't know that there is an option as hovering is not an option here.
Created attachment 367517 [details] [review] Set opacity of properties button to 0.5 Drop opacity to 0.5 in none active case, makes it more eye-pleasent. Furthermore hovering then still have an effect too.
Review of attachment 367517 [details] [review]: IMO it looked better before, but I don't see any better solution, so OK. ::: src/resources/epiphany.css @@ +127,2 @@ .bookmarks-row button { + opacity: 0.5; } This file is actually generated from epiphany.scss by parse-sass.sh... your change is going to get lost next time the script is run. It's not run automatically during the build because it depends on the epiphany source directory being located in the same directory as the GTK+ source directory, as would be the case when building from a JHBuild checkout. I normally don't like checking generated files into git, and it's not very robust, but it works. You could try to get the script to work for you, but it'd probably be easier to just make the corresponding change in epiphany.scss and not bother with trying to regenerate epiphany.css, since the change is simple. (Regenerating the CSS file will also bring in a bunch of unrelated changes from upstream Adwaita, so if you decide to try that, it's best to regenerate it while making no changes to the SCSS source in a first commit, and then make your actual changes in a second commit.)
I have not looked much into it, but isn't it possible to detect if the user has touchpad enabled on its device or not? Even if it's not used, we could at least only make it always visible for touchpad capable devices only.
Beside the fact if it is possible or not: Do you really think it is worth the trouble? Starting here will cause different UIs which have to be tested and always have the habbit to break. Just my two cents.
Created attachment 367579 [details] [review] Set opacity of properties button to 0.25 - V2
(In reply to Jan-Michael Brummer from comment #5) > Beside the fact if it is possible or not: Do you really think it is worth > the trouble? Starting here will cause different UIs which have to be tested > and always have the habbit to break. Just my two cents. Yeah, it's better to have just one UI in all cases. That also avoids fun questions like what the expected behavior should be if your secondary monitor is a touchscreen and you've dragged the window such that it is displaying across two monitors....
(In reply to Jan-Michael Brummer from comment #6) > Created attachment 367579 [details] [review] [review] > Set opacity of properties button to 0.25 - V2 The patch has to edit both files... I'll push this, with that change.