GNOME Bugzilla – Bug 772216
Take advantage of Unicode
Last modified: 2017-12-05 15:46:40 UTC
Created attachment 336570 [details] [review] Use Unicode in translatable strings Attached patches convert ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
LGTM How did you produce that patch? If not manually, it might be worth sharing your method.
It's all manual, I'm afraid. Thanks for the review, but the patch should wait until gdk-pixbuf-2-36 is branched.
Piotr, could you please update the patch? Half of it seems to have been applied already.
Created attachment 365033 [details] [review] Use Unicode in translatable strings Are you sure? Rebasing on current master makes for the same patch.
I needed to apply it by hand: $ git bz apply https://bugzilla.gnome.org/show_bug.cgi?id=772216 Bug 772216 - Take advantage of Unicode 365033 - Use Unicode in translatable strings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Use Unicode in translatable strings Using index info to reconstruct a base tree... error: patch failed: gdk-pixbuf/io-gdip-jpeg.c:51 error: gdk-pixbuf/io-gdip-jpeg.c: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. Patch failed at 0001 Use Unicode in translatable strings The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Use-Unicode-in-translatable-strings-NmiDDE.patch
Attachment 365033 [details] pushed as 37cdb6c - Use Unicode in translatable strings