GNOME Bugzilla – Bug 772212
Fix some leaks
Last modified: 2016-09-29 22:22:18 UTC
All catched with valgrind while I was playing with Bug 772178
Created attachment 336557 [details] [review] panel-schedule: don't leak GMenu 761 (48 direct, 713 indirect) bytes in 1 blocks are definitely lost in loss record 16,640 of 17,238 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA20D90E: g_malloc (gmem.c:94) by 0xA227A55: g_slice_alloc (gslice.c:1025) by 0xA227A95: g_slice_alloc0 (gslice.c:1051) by 0x9D85A6F: g_type_create_instance (gtype.c:1848) by 0x9D6CED0: g_object_new_internal (gobject.c:1783) by 0x9D6D3DF: g_object_newv (gobject.c:1930) by 0x9D6CA81: g_object_new (gobject.c:1623) by 0x8DA8352: g_menu_new (gmenu.c:249) by 0x42E64C: gtd_panel_scheduled_init (gtd-panel-scheduled.c:495) by 0x9D85B32: g_type_create_instance (gtype.c:1866) by 0x9D6CED0: g_object_new_internal (gobject.c:1783)
Created attachment 336558 [details] [review] panel-today: don't leak GMenu 761 (48 direct, 713 indirect) bytes in 1 blocks are definitely lost in loss record 16,350 of 16,929 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA20D90E: g_malloc (gmem.c:94) by 0xA227A55: g_slice_alloc (gslice.c:1025) by 0xA227A95: g_slice_alloc0 (gslice.c:1051) by 0x9D85A6F: g_type_create_instance (gtype.c:1848) by 0x9D6CED0: g_object_new_internal (gobject.c:1783) by 0x9D6D3DF: g_object_newv (gobject.c:1930) by 0x9D6CA81: g_object_new (gobject.c:1623) by 0x8DA8352: g_menu_new (gmenu.c:249) by 0x42D2D8: gtd_panel_today_init (gtd-panel-today.c:320) by 0x9D85B32: g_type_create_instance (gtype.c:1866) by 0x9D6CED0: g_object_new_internal (gobject.c:1783)
Created attachment 336559 [details] [review] panel-today: don't leak title 6 bytes in 1 blocks are definitely lost in loss record 149 of 16,851 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA1F890E: g_malloc (gmem.c:94) by 0xA1F8BF0: g_malloc_n (gmem.c:331) by 0xA215121: g_strdup (gstrfuncs.c:363) by 0x42D384: gtd_panel_today_init (gtd-panel-today.c:315) by 0x9D70B32: g_type_create_instance (gtype.c:1866) by 0x9D57ED0: g_object_new_internal (gobject.c:1783) by 0x9D583DF: g_object_newv (gobject.c:1930) by 0x9D57A81: g_object_new (gobject.c:1623) by 0x42D4CF: gtd_panel_today_new (gtd-panel-today.c:344) by 0x42A657: gtd_plugin_eds_init (gtd-plugin-eds.c:352) by 0x9D70B32: g_type_create_instance (gtype.c:1866)
Created attachment 336560 [details] [review] eds: don't leak panels and fix dangling pointers 47 bytes in 1 blocks are definitely lost in loss record 8,461 of 16,914 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA9E5247: vasprintf (in /usr/lib64/libc-2.24.so) by 0xA25A3FC: g_vasprintf (gprintf.c:316) by 0xA22A2F7: g_strdup_vprintf (gstrfuncs.c:514) by 0xA22A39C: g_strdup_printf (gstrfuncs.c:540) by 0x4263DD: gtd_task_list_view_set_task_list (gtd-task-list-view.c:1097) by 0x42D3CF: gtd_panel_today_init (gtd-panel-today.c:329) by 0x9D85B32: g_type_create_instance (gtype.c:1866) by 0x9D6CED0: g_object_new_internal (gobject.c:1783) by 0x9D6D3DF: g_object_newv (gobject.c:1930) by 0x9D6CA81: g_object_new (gobject.c:1623) by 0x42D471: gtd_panel_today_new (gtd-panel-today.c:344) 47 bytes in 1 blocks are definitely lost in loss record 8,462 of 16,914 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA9E5247: vasprintf (in /usr/lib64/libc-2.24.so) by 0xA25A3FC: g_vasprintf (gprintf.c:316) by 0xA22A2F7: g_strdup_vprintf (gstrfuncs.c:514) by 0xA22A39C: g_strdup_printf (gstrfuncs.c:540) by 0x4263DD: gtd_task_list_view_set_task_list (gtd-task-list-view.c:1097) by 0x42E738: gtd_panel_scheduled_init (gtd-panel-scheduled.c:504) by 0x9D85B32: g_type_create_instance (gtype.c:1866) by 0x9D6CED0: g_object_new_internal (gobject.c:1783) by 0x9D6D3DF: g_object_newv (gobject.c:1930) by 0x9D6CA81: g_object_new (gobject.c:1623) by 0x42E820: gtd_panel_scheduled_new (gtd-panel-scheduled.c:524)
Created attachment 336561 [details] [review] task-list-view: don't leak css string 47 bytes in 1 blocks are definitely lost in loss record 8,452 of 16,866 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA9E5247: vasprintf (in /usr/lib64/libc-2.24.so) by 0xA25A3FC: g_vasprintf (gprintf.c:316) by 0xA22A2F7: g_strdup_vprintf (gstrfuncs.c:514) by 0xA22A39C: g_strdup_printf (gstrfuncs.c:540) by 0x4263DD: gtd_task_list_view_set_task_list (gtd-task-list-view.c:1097) by 0x42E744: gtd_panel_scheduled_init (gtd-panel-scheduled.c:505) by 0x9D85B32: g_type_create_instance (gtype.c:1866) by 0x9D6CED0: g_object_new_internal (gobject.c:1783) by 0x9D6D3DF: g_object_newv (gobject.c:1930) by 0x9D6CA81: g_object_new (gobject.c:1623) by 0x42E82C: gtd_panel_scheduled_new (gtd-panel-scheduled.c:525)
Created attachment 336562 [details] [review] window: don't leak GtdNotification 163 (40 direct, 123 indirect) bytes in 1 blocks are definitely lost in loss record 15,207 of 16,913 at 0x9D709EF: g_type_create_instance (gtype.c:1844) by 0x9D57ED0: g_object_new_internal (gobject.c:1783) by 0x9D58B24: g_object_new_valist (gobject.c:2042) by 0x9D57AD0: g_object_new (gobject.c:1626) by 0x412EE6: gtd_notification_new (gtd-notification.c:285) by 0x429795: gtd_window_init (gtd-window.c:817) by 0x9D70B32: g_type_create_instance (gtype.c:1866) by 0x9D57ED0: g_object_new_internal (gobject.c:1783) by 0x9D58B24: g_object_new_valist (gobject.c:2042) by 0x9D57AD0: g_object_new (gobject.c:1626) by 0x429033: gtd_window_new (gtd-window.c:633) by 0x41CBF8: run_window (gtd-application.c:169)
Created attachment 336563 [details] [review] plugin-dialog: don't leak GList 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 9,427 of 17,018 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA1F890E: g_malloc (gmem.c:94) by 0xA212A55: g_slice_alloc (gslice.c:1025) by 0xA1EC308: g_list_prepend (glist.c:311) by 0x5EE5C42: gtk_container_children_callback (gtkcontainer.c:3304) by 0x5FE6773: gtk_list_box_forall (gtklistbox.c:2545) by 0x5EE438A: gtk_container_foreach (gtkcontainer.c:2472) by 0x5EE4591: gtk_container_get_children (gtkcontainer.c:2536) by 0x420505: plugin_loaded (gtd-plugin-dialog.c:115) by 0x9F99C57: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.2) by 0x9F996B9: ffi_call (in /usr/lib64/libffi.so.6.0.2) by 0x9D51662: g_cclosure_marshal_generic_va (gclosure.c:1604)
Created attachment 336564 [details] [review] task-list: don't leak GdkRGBA color 192 bytes in 6 blocks are definitely lost in loss record 15,388 of 16,885 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA1F890E: g_malloc (gmem.c:94) by 0xA212A55: g_slice_alloc (gslice.c:1025) by 0xA212AD7: g_slice_copy (gslice.c:1076) by 0x678E912: gdk_rgba_copy (gdkrgba.c:76) by 0x423910: gtd_task_list_get_color (gtd-task-list.c:306) by 0x4233DD: gtd_task_list_get_property (gtd-task-list.c:83) by 0x9D5717E: object_get_property (gobject.c:1378) by 0x9D59E7F: g_object_get_property (gobject.c:2446) by 0x9D49E90: on_source_notify (gbinding.c:316) by 0x9D53F16: g_cclosure_marshal_VOID__PARAM (gmarshal.c:1832) by 0x9D4F8B9: g_closure_invoke (gclosure.c:804)
Created attachment 336565 [details] [review] window: don't leak queued notification 358 (40 direct, 318 indirect) bytes in 1 blocks are definitely lost in loss record 15,870 of 16,820 at 0x9D709EF: g_type_create_instance (gtype.c:1844) by 0x9D57ED0: g_object_new_internal (gobject.c:1783) by 0x9D58B24: g_object_new_valist (gobject.c:2042) by 0x9D57AD0: g_object_new (gobject.c:1626) by 0x412EE6: gtd_notification_new (gtd-notification.c:285) by 0x428D5F: gtd_window__show_error_message (gtd-window.c:543) by 0x9F99C57: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.2) by 0x9F996B9: ffi_call (in /usr/lib64/libffi.so.6.0.2) by 0x9D51662: g_cclosure_marshal_generic_va (gclosure.c:1604) by 0x9D4FB51: _g_closure_invoke_va (gclosure.c:867) by 0x9D6A41A: g_signal_emit_valist (gsignal.c:3300) by 0x9D6B59E: g_signal_emit (gsignal.c:3447)
Created attachment 336566 [details] [review] task-list-view: don't leak GList of GtdTask 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 9,485 of 17,147 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0xA1F890E: g_malloc (gmem.c:94) by 0xA212A55: g_slice_alloc (gslice.c:1025) by 0xA1EC8DA: g_list_copy_deep (glist.c:678) by 0xA1EC8A7: g_list_copy (glist.c:633) by 0x426036: gtd_task_list_view_set_list (gtd-task-list-view.c:968) by 0x4264A5: gtd_task_list_view_set_task_list (gtd-task-list-view.c:1118) by 0x41B5E4: gtd_list_selector_panel_list_selected (gtd-list-selector-panel.c:250) by 0x9D544E7: g_cclosure_marshal_VOID__OBJECT (gmarshal.c:2062) by 0x9D4F8B9: g_closure_invoke (gclosure.c:804) by 0x9D6BD25: signal_emit_unlocked_R (gsignal.c:3635) by 0x9D6B05C: g_signal_emit_valist (gsignal.c:3391)
Thanks! Attachment 336557 [details] pushed as 13b23b0 - panel-schedule: don't leak GMenu Attachment 336558 [details] pushed as efe3085 - panel-today: don't leak GMenu Attachment 336559 [details] pushed as 45e5f68 - panel-today: don't leak title Attachment 336560 [details] pushed as 4f29174 - eds: don't leak panels Attachment 336561 [details] pushed as d2d7521 - task-list-view: don't leak css string Attachment 336562 [details] pushed as 5ffffee - window: don't leak GtdNotification Attachment 336563 [details] pushed as f511957 - plugin-dialog: don't leak GList Attachment 336564 [details] pushed as 0a26739 - task-list: don't leak GdkRGBA color Attachment 336565 [details] pushed as 59faad1 - window: don't leak queued notification Attachment 336566 [details] pushed as a4c742a - task-list-view: don't leak GList of GtdTask