GNOME Bugzilla – Bug 772208
In Universal builds, post-build "shell" command goes to wrong place
Last modified: 2016-10-14 16:06:01 UTC
If a universal build and one selects "0" to get a shell, it goes to the first recipe in the list instead of to the one that failed. I'm attaching two possible patches to fix it, the first adds the architecture to the exception and bubbles it up that way. The second just sets the current arch on the Universal recipe so that getattr afterwards are redirected to it.. I'm not sure at all which one is better although I tend towrds the exception based one.
Created attachment 336551 [details] [review] Put the arch in the exception to run shell in the right place
Created attachment 336552 [details] [review] Go to the right directory on failed Universal builds Instead of picking a random architecture, instead save the failed one and use it.
I think embedding the arch in the exception is cleaner than mutable state on the recipe. Only reason to go with the latter is if we foresee needing the current_arch information in any other scenario.
Review of attachment 336551 [details] [review]: Merged as: commit a0a134fdf6aadc7d527600b1edc4563b947f07eb Author: Olivier Crête <olivier.crete@collabora.com> Date: Thu Sep 29 17:19:44 2016 -0400 Go to the right directory on failed Universal builds Instead of picking a random architecture, instead save the failed on in the exception and use it to go to the right directory. https://bugzilla.gnome.org/show_bug.cgi?id=772208
Review of attachment 336552 [details] [review]: It's cleaner in an exception, so use the other one