After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772138 - Several issues in splitmuxsrc
Several issues in splitmuxsrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-28 19:14 UTC by Jan Schmidt
Modified: 2016-09-30 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
splitmuxsrc: Avoid stall when parts get out of sync (3.80 KB, patch)
2016-09-28 19:15 UTC, Jan Schmidt 		committed Details | Review
splitmuxsrc: Fix extra unref handling queries (800 bytes, patch)
2016-09-28 19:15 UTC, Jan Schmidt 		committed Details | Review
splitmuxsrc: Drop lock shutting down pads (1.13 KB, patch)
2016-09-28 19:15 UTC, Jan Schmidt 		committed Details | Review
splitmuxsrc: Handle stop point from segment (1.87 KB, patch)
2016-09-28 19:15 UTC, Jan Schmidt 		committed Details | Review

Description Jan Schmidt 2016-09-28 19:14:51 UTC 
I found a few issues in splitmuxsrc. I think all these patches are right to go in 1.10, and should get backported to 1.8
Comment 1 Jan Schmidt 2016-09-28 19:15:28 UTC 
Created attachment 336469 [details] [review]
splitmuxsrc: Avoid stall when parts get out of sync

When one part moves ahead of the others - due to excessive
downstream queueing, or really small input files - then
we can end up activating parts more than once. That can lead to
effects like shutting down pad tasks prematurely.
Comment 2 Jan Schmidt 2016-09-28 19:15:34 UTC 
Created attachment 336470 [details] [review]
splitmuxsrc: Fix extra unref handling queries
Comment 3 Jan Schmidt 2016-09-28 19:15:40 UTC 
Created attachment 336471 [details] [review]
splitmuxsrc: Drop lock shutting down pads

Avoid a sporadic deadlock on shutdown by dropping
the splitmux lock around pad shutdown
Comment 4 Jan Schmidt 2016-09-28 19:15:47 UTC 
Created attachment 336472 [details] [review]
splitmuxsrc: Handle stop point from segment

If the seek stop point (or start, during reverse play)
was within the segment we just finished, go EOS immediately
instead of proceeding through all other parts and sending
0 length seeks to them.
Comment 5 Jan Schmidt 2016-09-30 14:41:48 UTC 
Pushed to 1.8 and master.