GNOME Bugzilla – Bug 772102
[PATCH] Implement XPath
Last modified: 2016-09-29 18:45:29 UTC
Created attachment 336416 [details] [review] [PATCH] Implement XPath This patch add 'evaluate' method to DomElement, so we can evaluate XPath expression on any node.
Review of attachment 336416 [details] [review]: I've committed your patch. Just I have to comment this: * We need to create a XPathContext interface to add related methods to it * Move the methods added to DomElement interface to XPathContext on * Declare GElemento to implement XPathContext * Need to add test cases * Need to declare the specification implemented by libxml2 and check if we can expand it to latest XPath 3.1 specification Doing to will keep DOM4 implementation clean from any other outside its own specification and will allow others to implement XPath.
Yanick, You forget to add your license. Please confirm I can set it to LGPL, in order to update your code.
of course. anyone can use & share my work on GXml :)
XPath.vala is missing
Ok. Thank you. I pushed all my latest changes, and the missing files, to upstream. Sorry for the missing XPath.vala file, this is a recurrent error I have (you know that). I uploaded XPath.vala updated with my changes; if you have any comment, file a bug and we can work on. Great job!!! License changes: https://git.gnome.org/browse/gxml/commit/?id=66270bf75332b5ba052cfc9859148d42981e63fa Missing files: https://git.gnome.org/browse/gxml/commit/?id=579af9bbad3e3b3664350846fd0658b042ff34ad PD. May you want to help to add test cases for your XPath implementation Bug #772194