After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772063 - batch-rename-dialog: use strlen for gtk_editable_insert_text
batch-rename-dialog: use strlen for gtk_editable_insert_text
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-27 14:45 UTC by Carlos Soriano
Modified: 2016-09-27 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
batch-rename-dialog: use strlen for gtk_editable_insert_text (1.38 KB, patch)
2016-09-27 14:45 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2016-09-27 14:45:03 UTC 
.
Comment 1 Carlos Soriano 2016-09-27 14:45:07 UTC 
Created attachment 336365 [details] [review]
batch-rename-dialog: use strlen for gtk_editable_insert_text

We were using utf8_lenght, which is the right approach to know the
number of characters. However, gtk_editable_insert_text expects bytes
rather than number of characters.

This was causing languages that have unicode characters in the tags
to have a buggy batch rename dialog.

To fix it, use strlen so we get the number of bytes.
Comment 2 Carlos Soriano 2016-09-27 14:47:48 UTC 
Attachment 336365 [details] pushed as 69b9d0b - batch-rename-dialog: use strlen for gtk_editable_insert_text