GNOME Bugzilla – Bug 772004
[PATCH] GSL bindings contain a few attribute typos
Last modified: 2016-09-27 15:46:23 UTC
Created attachment 336296 [details] [review] Patch for gsl.vapi This patch cleans up some of the typos present in the CCode attributes for the GNU Scientific Library (mostly stuff like cheader_filanme instead of cheader_filename).
Review of attachment 336296 [details] [review]: Correcting the typos for cheader_filename seems fine. I did have a look in http://git.savannah.gnu.org/cgit/gsl.git/tree/ for a single header that includes all the others, but there doesn't appear to be one. The only thing I think needs changing is IntegrationQAWOTable, which has an unref function, but no ref function. So I'm assuming it is a singly-owned class and should be bound as free_function = gsl_integration_qawo_table_free See https://wiki.gnome.org/Projects/Vala/LegacyBindings#Classes for more details.
Created attachment 336297 [details] [review] Patch for gsl.vapi w/ free_function instead of unref (In reply to Al Thomas from comment #1) > The only thing I think needs changing is IntegrationQAWOTable, which has an > unref function, but no ref function. So I'm assuming it is a singly-owned > class and should be bound as free_function = gsl_integration_qawo_table_free > See https://wiki.gnome.org/Projects/Vala/LegacyBindings#Classes for more > details. Oh, of course. I have to admit, I wasn't really paying attention when I changed that. I was just aiming to clear the compiler warnings :) Here's the ammended patch
Review of attachment 336297 [details] [review]: Looks fine to me. If you are going to do further work on this VAPI note that the usual coding style is to pad the equals sign with spaces, e.g. cheader_filename = "gsl/gsl_integration.h"
Alright, thanks!
commit 52406608968d7056adc6cefaab2a834d8b4c1636 Author: George Barrett <bob@bob131.so> Date: Tue Sep 27 05:00:24 2016 +1000 gsl.vapi: Fix attribute typos At the moment, the are a few CCode attributes containing typos in the bindings for the GNU Scientific Library. This patch rectifies the ones that valac explicitly complains about.