After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771995 - SIGILL on Intel Core 2 Duo caused by __builtin_ia32_rdtscp in egg_get_current_cpu_rdtscp()
SIGILL on Intel Core 2 Duo caused by __builtin_ia32_rdtscp in egg_get_current...
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 772323 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-26 17:16 UTC by Debarshi Ray
Modified: 2016-10-03 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egg-counter: Fix documentation typo (820 bytes, patch)
2016-09-26 17:27 UTC, Debarshi Ray
committed Details | Review
build: Define _GNU_SOURCE when using the Linux kernel for sched_getcpu (1.15 KB, patch)
2016-09-26 17:27 UTC, Debarshi Ray
committed Details | Review
build: Disable rdtscp by default (4.40 KB, patch)
2016-09-26 17:27 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2016-09-26 17:16:46 UTC
We should disable rdtscp by default because it is not portable across all x86_64 architectures. It is only present in various Core i[357] CPUs. Otherwise it crashes during start-up. See https://bugzilla.redhat.com/show_bug.cgi?id=1379166

We can use the GB_ENABLE_RDTSCP macro from gnome-builder instead of our own hand-rolled M4.
Comment 1 Debarshi Ray 2016-09-26 17:27:04 UTC
Created attachment 336288 [details] [review]
egg-counter: Fix documentation typo
Comment 2 Debarshi Ray 2016-09-26 17:27:26 UTC
Created attachment 336289 [details] [review]
build: Define _GNU_SOURCE when using the Linux kernel for sched_getcpu
Comment 3 Debarshi Ray 2016-09-26 17:27:53 UTC
Created attachment 336290 [details] [review]
build: Disable rdtscp by default
Comment 4 Debarshi Ray 2016-10-02 10:29:33 UTC
*** Bug 772323 has been marked as a duplicate of this bug. ***
Comment 5 Phil Reilly 2016-10-02 17:32:23 UTC
Is there a build package to download or do I have to build one to test these patches?
Comment 6 Phil Reilly 2016-10-02 17:36:54 UTC
(In reply to Phil Reilly from comment #5)
> Is there a build package to download or do I have to build one to test these
> patches?

...on an Arch system.
Comment 7 Aaron Paden 2016-10-02 17:54:57 UTC
I've applied the patches, and they appear to do the job on my end. gnome-photos is no longer crashing.
Comment 8 Aaron Paden 2016-10-02 17:58:08 UTC
Phil Reilly, see: https://wiki.archlinux.org/index.php/Patching_in_ABS#Applying_patches

Remember to also add the patches to the source array, and re-generate checksums with makepkg -g >>PKGBUILD

You'll need to install abs and edit /etc/abs.conf to enable the testing repos in abs.
Comment 9 Phil Reilly 2016-10-02 18:14:01 UTC
(In reply to Aaron Paden from comment #7)
> I've applied the patches, and they appear to do the job on my end.
> gnome-photos is no longer crashing.

Great Job!
Comment 10 Debarshi Ray 2016-10-03 14:00:24 UTC
(In reply to Aaron Paden from comment #7)
> I've applied the patches, and they appear to do the job on my end.
> gnome-photos is no longer crashing.

Thanks for trying them out.
Comment 11 Debarshi Ray 2016-10-03 14:01:16 UTC
This will be part of the next tarball release in the GNOME 3.22.x series.