After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771957 - Suggestion: Make the Programming bit marker labels dim (and fix a typo along the way!)
Suggestion: Make the Programming bit marker labels dim (and fix a typo along ...
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-25 21:00 UTC by Daniel Boles
Modified: 2016-10-04 06:31 UTC
See Also:
GNOME target: ---
GNOME version: 3.21/3.22


Attachments
before: light (29.24 KB, image/png)
2016-09-25 21:03 UTC, Daniel Boles
  Details
after: light (30.95 KB, image/png)
2016-09-25 21:03 UTC, Daniel Boles
  Details
before: dark (27.64 KB, image/png)
2016-09-25 21:04 UTC, Daniel Boles
  Details
after: dark (28.22 KB, image/png)
2016-09-25 21:04 UTC, Daniel Boles
  Details
buttons-programming.ui: fix a typo in one of the bit_marker Labels (924 bytes, patch)
2016-09-25 21:16 UTC, Daniel Boles
committed Details | Review
buttons-programming.ui: give the bit_marker Labels the dim-label style class (2.85 KB, patch)
2016-09-25 21:17 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2016-09-25 21:00:25 UTC
The bit marker labels are less important than the bit digits, but at the moment, they have the same colour and end up making things look a bit cluttered.

Giving them the dim-label style class makes them look nicer IMO. Also, it more clearly conveys the idea that, unlike the bit digits, they can't be clicked on.

While trying this, I also noticed that one of them had an id of "bit_maker", so it's missing the 1st "r". It looks like this can be fixed without consequence.

Screenshots and patches to follow. Hope this is useful!
Comment 1 Daniel Boles 2016-09-25 21:03:28 UTC
Created attachment 336235 [details]
before: light
Comment 2 Daniel Boles 2016-09-25 21:03:53 UTC
Created attachment 336236 [details]
after: light
Comment 3 Daniel Boles 2016-09-25 21:04:17 UTC
Created attachment 336237 [details]
before: dark
Comment 4 Daniel Boles 2016-09-25 21:04:41 UTC
Created attachment 336238 [details]
after: dark
Comment 5 Daniel Boles 2016-09-25 21:16:27 UTC
Created attachment 336239 [details] [review]
buttons-programming.ui: fix a typo in one of the bit_marker Labels
Comment 6 Daniel Boles 2016-09-25 21:17:15 UTC
Created attachment 336240 [details] [review]
buttons-programming.ui: give the bit_marker Labels the dim-label style class
Comment 7 Robert Roth 2016-10-04 06:31:38 UTC
Thank you, patches look fine, and they indeed improve the look of the programming view.
Attachment 336239 [details] pushed as 929512c - buttons-programming.ui: fix a typo in one of the bit_marker Labels
Attachment 336240 [details] pushed as 84f4d2b - buttons-programming.ui: give the bit_marker Labels the dim-label style class