GNOME Bugzilla – Bug 771928
mime-application-chooser: port to use G_DECLARE* type declarations
Last modified: 2016-10-07 13:01:14 UTC
See bug 771777.
Created attachment 336783 [details] [review] mime-application-chooser: port to G_DECLARE* type Currently we are using the old GObject class declarations, which have two problems. One problem is that we cannot use smart pointers like g_autoptr. The other problem is the boilerplate code generated that makes the code less readable, so harder to understand. To fix this use G_DECLARE* type.
Review of attachment 336783 [details] [review]: Looking good, just a nitpick ::: src/nautilus-mime-application-chooser.h @@ +31,1 @@ +#define NAUTILUS_TYPE_MIME_APPLICATION_CHOOSER (nautilus_mime_application_chooser_get_type ()) not need to indent this, it's not aligned with anything under it.
Created attachment 337086 [details] [review] mime-application-chooser: port to G_DECLARE* type Currently we are using the old GObject class declarations, which have two problems. One problem is that we cannot use smart pointers like g_autoptr. The other problem is the boilerplate code generated that makes the code less readable, so harder to understand. To fix this use G_DECLARE* type.
Review of attachment 337086 [details] [review]: It's good, thanks!
Attachment 337086 [details] pushed as 47d7792 - mime-application-chooser: port to G_DECLARE* type