After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771928 - mime-application-chooser: port to use G_DECLARE* type declarations
mime-application-chooser: port to use G_DECLARE* type declarations
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 771777
 
 
Reported: 2016-09-25 08:05 UTC by Ernestas Kulik
Modified: 2016-10-07 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mime-application-chooser: port to G_DECLARE* type (14.82 KB, patch)
2016-10-02 22:11 UTC, Sirbu Lavinia Stefania
none Details | Review
mime-application-chooser: port to G_DECLARE* type (14.82 KB, patch)
2016-10-06 17:56 UTC, Sirbu Lavinia Stefania
committed Details | Review

Description Ernestas Kulik 2016-09-25 08:05:38 UTC
See bug 771777.
Comment 1 Sirbu Lavinia Stefania 2016-10-02 22:11:53 UTC
Created attachment 336783 [details] [review]
mime-application-chooser: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.
Comment 2 Carlos Soriano 2016-10-04 20:40:25 UTC
Review of attachment 336783 [details] [review]:

Looking good, just a nitpick

::: src/nautilus-mime-application-chooser.h
@@ +31,1 @@
+#define NAUTILUS_TYPE_MIME_APPLICATION_CHOOSER         (nautilus_mime_application_chooser_get_type ())

not need to indent this, it's not aligned with anything under it.
Comment 3 Sirbu Lavinia Stefania 2016-10-06 17:56:39 UTC
Created attachment 337086 [details] [review]
mime-application-chooser: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.
Comment 4 Carlos Soriano 2016-10-07 07:51:33 UTC
Review of attachment 337086 [details] [review]:

It's good, thanks!
Comment 5 Ernestas Kulik 2016-10-07 13:01:09 UTC
Attachment 337086 [details] pushed as 47d7792 - mime-application-chooser: port to G_DECLARE* type