After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771887 - nautilus no longer allows the "--no-desktop" command-line argument
nautilus no longer allows the "--no-desktop" command-line argument
Status: RESOLVED DUPLICATE of bug 771051
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-23 17:03 UTC by Dima Ryazanov
Modified: 2016-09-24 06:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
nautilus.1: remove unused options (1.76 KB, patch)
2016-09-23 17:33 UTC, Ernestas Kulik
none Details | Review
nautilus.1: flag deprecated options (1.83 KB, patch)
2016-09-23 19:04 UTC, Ernestas Kulik
none Details | Review
nautilus.1: flag deprecated options (1.94 KB, patch)
2016-09-23 19:41 UTC, Ernestas Kulik
committed Details | Review

Description Dima Ryazanov 2016-09-23 17:03:06 UTC
Starting with Gnome 3.22, nautilus rejects the "--no-desktop" option:

$ nautilus --no-desktop
Unknown option --no-desktop

I'm guessing it just doesn't support desktop anymore - however, it should still allow (and ignore) the option - otherwise, it breaks any application that relies on the old behavior. In particular, in breaks Dropbox: right-clicking the tray icon and selecting "Open Dropbox Folder" or clicking anything in "Recently Changed Files" has no effect. (Of course, ideally, Dropbox shouldn't run "nautilus" directly - however, it needs the "--select" option, which is not exposed by "xdg-open".)

Also, "--no-desktop" was removed from "--help", but is still mentioned in the man page.
Comment 1 Ernestas Kulik 2016-09-23 17:22:25 UTC
Ah, the manpage is on me, I was the last one to update it. Will attach a patch in a bit.

This seems to have been resolved in master.
Comment 2 Dima Ryazanov 2016-09-23 17:28:08 UTC
Oh yeah, found an existing bug for this.

*** This bug has been marked as a duplicate of bug 771051 ***
Comment 3 Ernestas Kulik 2016-09-23 17:33:21 UTC
Created attachment 336169 [details] [review]
nautilus.1: remove unused options

Some command-line options are no longer used and should not be mentioned
in the manual page.
Comment 4 Carlos Soriano 2016-09-23 18:53:54 UTC
Review of attachment 336169 [details] [review]:

Wwe should add a deprecation instead of just removing it, since it's actually not removed.
Comment 5 Ernestas Kulik 2016-09-23 18:56:34 UTC
(In reply to Carlos Soriano from comment #4)
> Review of attachment 336169 [details] [review] [review]:
> 
> Wwe should add a deprecation instead of just removing it, since it's
> actually not removed.

But they are only used for compatibility reasons. I do not see a reason to advertise them, personally.
Comment 6 Carlos Soriano 2016-09-23 18:58:11 UTC
(In reply to Ernestas Kulik from comment #5)
> (In reply to Carlos Soriano from comment #4)
> > Review of attachment 336169 [details] [review] [review] [review]:
> > 
> > Wwe should add a deprecation instead of just removing it, since it's
> > actually not removed.
> 
> But they are only used for compatibility reasons. I do not see a reason to
> advertise them, personally.

For some time we need to tell apps using it, like Dropbox, what did we do with this and why is not necessary anymore.
Comment 7 Ernestas Kulik 2016-09-23 19:04:02 UTC
Created attachment 336170 [details] [review]
nautilus.1: flag deprecated options

Some command-line options have been deprecated and should be advertised
as such.
Comment 8 Ernestas Kulik 2016-09-23 19:05:47 UTC
One of them was actually removed, so I removed it from the manual page as well. Moved the version option to match the arrangement in the help text.
Comment 9 Carlos Soriano 2016-09-23 19:17:01 UTC
Review of attachment 336170 [details] [review]:

Just two comments

::: docs/nautilus.1
@@ +41,2 @@
 .BR \-g ", " \-\-geometry=\fIGEOMETRY\fR
+Create the initial window with the given geometry. Deprecated.

Could you add "it's no longer supported, since the geometry should be set by the user and saved in gsettings as currently Nautilus does"

@@ +52,3 @@
 .TP
 .B \-\-no-desktop
+Never manage the desktop (ignore the GSettings preference). Deprecated.

could you add "It's not needed anymore since the desktop is now another binary"
Comment 10 Ernestas Kulik 2016-09-23 19:41:25 UTC
Created attachment 336171 [details] [review]
nautilus.1: flag deprecated options

Some command-line options have been deprecated and should be advertised
as such.
Comment 11 Carlos Soriano 2016-09-23 19:55:03 UTC
Review of attachment 336171 [details] [review]:

Perfect, thanks for improving what I said and not just copy paste my ****** English :)
Comment 12 Ernestas Kulik 2016-09-24 06:01:17 UTC
Comment on attachment 336171 [details] [review]
nautilus.1: flag deprecated options

Attachment 336171 [details] pushed as d3b332d - nautilus.1: flag deprecated options