GNOME Bugzilla – Bug 771880
Use separate link menu for play queue
Last modified: 2018-05-24 19:10:45 UTC
Currently, the menu for 'playlist' is used for 'play queue'. However, the following items are not valid for play queue. 1. Edit 2. Rename 3. Queue all tracks 4. Shuffle ( as it is already available in source toolbar ). Also, the menu has 'playlist' as name, which doesn't fit with play queue. It is cleaner and better to use a separate menu for play queue.
Created attachment 336157 [details] Current toolbar menu for play queue
Created attachment 336158 [details] Separate menu for play queue
Created attachment 336159 [details] [review] Use separate menu for play queue
Created attachment 336160 [details] [review] Refactor multiple calls to g_application_get_default()
Review of attachment 336159 [details] [review]: where is queue-menu.ui?
Created attachment 337735 [details] [review] Separate menu for play queue Add missed out queue-menu.ui file.
Review of attachment 337735 [details] [review]: if you only have one item to put in a menu, you don't need a menu. I guess the shuffle item should move in there too.
"Create Audio CD..." is added to the menu, when 'Audio CD Recorder' plugin is enabled. I think 'Shuffle' and 'Clear' for queue are very frequently used, and so should not be moved under queue menu. I don't see an issue with a single menu item, but if it appears so, then something else needs to be done ( maybe, 'Show in side pane' )
Even two items is still too small, but acceptable if there's really nothing else that fits. One is absurd. 'show in side pane' wouldn't really work there.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1518.