GNOME Bugzilla – Bug 771871
lv2 plugin doesn't do processing in case of mono sound
Last modified: 2016-09-30 07:05:52 UTC
Hi I have a scenario with processing mono audio with lv2 plugin. It doesn't not work. Most likely the root of the problem is in ext/lv2/stlv2filter.c function gst_lv2_filter_transform_data: the allocated array (in) to be processed in lv2 is filled with input data only in case of number of lv2 input ports more than 1 (most likely should be MORE OR EQUALS 1). In case when lv2_group->ports->len == 1 the array "in" is not initialized with data from the in_map but passed to the function lilv_instance_connect_port. Definitely the same situation happens with storing of processed data form the out array to the out_map Thanks Sergey
Created attachment 336463 [details] [review] patch with fix possible fix
Thanks, looks good. I'll test it a bit.
btw. which plugins did you test with?
Ideally please attach patches in git format against HEAD. git add ext/lv2/gstlv2filter.c git commit <type message> git format-patch origin/master The current patch does not apply :/
(In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #3) > btw. which plugins did you test with? I tested the plugin of my customer. Sorry cannot share it.
Created attachment 336496 [details] [review] git patch against HEAD.
(In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #4) > Ideally please attach patches in git format against HEAD. > > git add ext/lv2/gstlv2filter.c > git commit > <type message> > > git format-patch origin/master > > The current patch does not apply :/ done
The following fix has been pushed: e985754 fix for https://bugzilla.gnome.org/show_bug.cgi?id=771871
Created attachment 336532 [details] [review] fix for https://bugzilla.gnome.org/show_bug.cgi?id=771871
In future please use a git message like: --------------------------------------------------------- lv2: fix handling of mono audio Fixes https://bugzilla.gnome.org/show_bug.cgi?id=771871 --------------------------------------------------------- Thanks for the patch! :)
ok, i will thanks alot for your help