After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771851 - Vertical ruler shows artifacts if the status bar isn't showing
Vertical ruler shows artifacts if the status bar isn't showing
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-09-22 17:36 UTC by Elle Stone
Modified: 2016-09-22 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Elle Stone 2016-09-22 17:36:46 UTC
If the user hides the status bar (View menu, uncheck "Show Statusbar"), and the rulers are shown, then moving paint tools, eyedropper, etc (mouse or tablet stylus) vertically over the image causes artifacts to show in the vertical ruler. No artifacts show in the horizontal ruler regardless of the direction the cursor is moved. This happens in single and multiple window mode. Checked on gentoo and debian linux using babl/GEGL/GIMP updated today (commit 472608f).
Comment 1 Michael Natterer 2016-09-22 20:11:40 UTC
Happens on 2.8 too and is a complete WTF...
Comment 2 Michael Natterer 2016-09-22 20:44:51 UTC
It goes away when disabling the optimization from commit
3233a70bae756e8f62fb144cbce9d8f84ed25609 but I still have
no clue how this can be related to the statusbar...
Comment 3 Michael Natterer 2016-09-22 21:12:23 UTC
Fixed in master and gimp-2-8:

commit c2d63da7d9f6a7fd5bf8d49444d41596402f2475
Author: Michael Natterer <mitch@gimp.org>
Date:   Thu Sep 22 23:03:53 2016 +0200

    Bug 771851 - Vertical ruler shows artifacts if the status bar isn't showing
    
    gimp_ruler_draw_pos(): when remembering the just drawn rectangle's
    position, don't just unconditionally overwrite the previous position's
    rectangle. Instead, if the previous position's rectangle has not been
    cleared yet (has a non-zero size), remember the union of old and new
    rectangle.
    
    Why this only happened to the vertical ruler with statusbar off is
    beyond my mind, it should have always produced artifacts.
    
    Unrelated: make sure the idle function is removed if we decide to
    immediately redraw in gimp_ruler_set_position().
    
    (cherry picked from commit e909b77969ea29c882ee38b622c4507e7302c705)

 libgimpwidgets/gimpruler.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)