Created attachment 336841 [details] [review]
file-conflict-dialog: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 336841 [details] [review]:

It looks mostly good! Just a nitpick:

::: src/nautilus-file-conflict-dialog.c
@@ +319,3 @@
+
+    fcd->skip_button =
+        gtk_dialog_add_button (dialog, _("_Skip"), CONFLICT_RESPONSE_SKIP);

actually we should do the oposite:
fcd->skip_button = gtk_dialog_add_button (dialog,
                                          _("_Skip"), CONFLICT_RESPONSE_SKIP);

The first line after the equal goes in the same line of the equal.

Created attachment 337087 [details] [review]
file-conflict-dialog: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 337087 [details] [review]:

Looking mostly good! You forgot:

::: src/nautilus-file-conflict-dialog.h
@@ +28,3 @@
 #include <gtk/gtk.h>
 
+G_BEGIN_DECLS

you forgot the G_END_DECLS

Created attachment 337093 [details] [review]
file-conflict-dialog: port to G_DECLARE* type

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.

Review of attachment 337093 [details] [review]:

Looks good now, thanks!

Attachment 337093 [details] pushed as 4e4d4df - file-conflict-dialog: port to G_DECLARE* type