After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771837 - bookmark: port to G_DECLARE* type declaration
bookmark: port to G_DECLARE* type declaration
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.21.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 771777
 
 
Reported: 2016-09-22 14:53 UTC by Ernestas Kulik
Modified: 2016-10-07 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bookmark: port to G_DECLARE* type declarations (19.97 KB, patch)
2016-10-06 20:31 UTC, Sirbu Lavinia Stefania 		none Details | Review
bookmark: port to G_DECLARE* type declarations (20.41 KB, patch)
2016-10-06 21:22 UTC, Sirbu Lavinia Stefania 		committed Details | Review

Description Ernestas Kulik 2016-09-22 14:53:43 UTC 
See bug 771777.

This is pretty straightforward, there is not a whole lot of code.
Comment 1 Sirbu Lavinia Stefania 2016-10-06 20:31:18 UTC 
Created attachment 337109 [details] [review]
bookmark: port to G_DECLARE* type declarations

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.
Comment 2 Sirbu Lavinia Stefania 2016-10-06 21:22:06 UTC 
Created attachment 337112 [details] [review]
bookmark: port to G_DECLARE* type declarations

Currently we are using the old GObject class declarations, which have two
problems.

One problem is that we cannot use smart pointers like g_autoptr. The other
problem is the boilerplate code generated that makes the code less readable,
so harder to understand.

To fix this use G_DECLARE* type.
Comment 3 Ernestas Kulik 2016-10-07 06:57:12 UTC 
Review of attachment 337112 [details] [review]:

LGTM
Comment 4 Carlos Soriano 2016-10-07 07:06:08 UTC 
Review of attachment 337112 [details] [review]:

Thanks Lavinia!
Comment 5 Ernestas Kulik 2016-10-07 13:00:08 UTC 
Attachment 337112 [details] pushed as 0b617a3 - bookmark: port to G_DECLARE* type declarations