After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771765 - Problem with 80 character lines and header comments
Problem with 80 character lines and header comments
Status: RESOLVED DUPLICATE of bug 673655
Product: gtranslator
Classification: Other
Component: Parse engine
HEAD
Other Linux
: Normal major
: ---
Assigned To: gtranslator-maint
gtranslator-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-21 13:20 UTC by Daniel Mustieles
Modified: 2018-09-03 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Mustieles 2016-09-21 13:20:18 UTC
When parser adds the current year to header comments, sometimes it generates a new line, starting with ",", and this breaks PO file structure.

This behaviour seems to be due to an 80 characters per line limitation. I've searched in the source code, but didn't find where this limit is set...

The file whre this comment is added to PO file is gtr-header.c, lines 682-690, but I think the problem is not there, but might help to investigate.

Could somebody please help with this issue? Please note that severity of this bug is high, because if PO file has a wrong structure, module's build might fail.

Thanks in advance
Comment 1 Daniel Mustieles 2016-09-22 14:59:43 UTC
Investigating, the 80 characters limitation is done by gettext...

Maybe a good idea would be to reduce the line's lenght, instead of adding the full list of years, just left a 'first_year - last_year' field would be enough to avoid the problem.

This should be relatively easy to do... would you consider it as a valid fix for this issue?
Comment 2 Gunnar Hjalmarsson 2018-02-23 18:27:05 UTC
This just caused a problem on the Ubuntu side, where Launchpad refused to import the es.po file. Fixed in git now.

https://gitlab.gnome.org/GNOME/gnome-todo/commit/124c798d
Comment 3 Piotr Drąg 2018-09-03 16:22:01 UTC

*** This bug has been marked as a duplicate of bug 673655 ***