Bug 771765 - Problem with 80 character lines and header comments
Problem with 80 character lines and header comments
Status: NEW
Product: gtranslator
Classification: Other
Component: Parse engine
HEAD
Other Linux
: Normal major
: ---
Assigned To: gtranslator-maint
gtranslator-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2016-09-21 13:20 UTC by Daniel Mustieles
Modified: 2017-07-10 12:06 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Mustieles 2016-09-21 13:20:18 UTC 
When parser adds the current year to header comments, sometimes it generates a new line, starting with ",", and this breaks PO file structure.

This behaviour seems to be due to an 80 characters per line limitation. I've searched in the source code, but didn't find where this limit is set...

The file whre this comment is added to PO file is gtr-header.c, lines 682-690, but I think the problem is not there, but might help to investigate.

Could somebody please help with this issue? Please note that severity of this bug is high, because if PO file has a wrong structure, module's build might fail.

Thanks in advance
Comment 1 Daniel Mustieles 2016-09-22 14:59:43 UTC 
Investigating, the 80 characters limitation is done by gettext...

Maybe a good idea would be to reduce the line's lenght, instead of adding the full list of years, just left a 'first_year - last_year' field would be enough to avoid the problem.

This should be relatively easy to do... would you consider it as a valid fix for this issue?
Note You need to log in before you can comment on or make changes to this bug.