After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771731 - window-list: Update icon on app changes
window-list: Update icon on app changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-20 16:06 UTC by Florian Müllner
Modified: 2016-09-20 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window-list: Update icon on app changes (1.96 KB, patch)
2016-09-20 16:06 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2016-09-20 16:06:05 UTC
See patch, and https://bugzilla.redhat.com/show_bug.cgi?id=1377438 for the corresponding downstream report.
Comment 1 Florian Müllner 2016-09-20 16:06:11 UTC
Created attachment 335943 [details] [review]
window-list: Update icon on app changes

We currently assume that the application associated with a particular
window is fixed. While this holds true for almost every application,
there are some cases of multi-app-packages like LibreOffice where
windows may change the properties used for application matching at
runtime. Catch those cases to make sure we display the correct icon
when the window shifts applications.
Comment 2 Rui Matos 2016-09-20 16:19:02 UTC
Review of attachment 335943 [details] [review]:

makes sense
Comment 3 Florian Müllner 2016-09-20 16:35:46 UTC
Attachment 335943 [details] pushed as f99b42e - window-list: Update icon on app changes