After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771728 - room-list: Fix room name alignment
room-list: Fix room name alignment
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-20 15:02 UTC by Florian Müllner
Modified: 2016-10-09 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
room-list: Fix room name alignment (1.31 KB, patch)
2016-09-20 15:02 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-09-20 15:02:54 UTC 
See patch.
Comment 1 Florian Müllner 2016-09-20 15:02:58 UTC 
Created attachment 335939 [details] [review]
room-list: Fix room name alignment

The visibility of the icon preceding a channel name is supposed to
depend on whether the channel represents a room or a private chat,
however as the icon is not excluded from show_all(), this only works
as intended for rooms joined later. While the icon is still empty
for the original set of rooms, the spacing between icon and label
results in names being aligned differently.
Comment 2 Bastian Ilsø 2016-10-09 15:18:30 UTC 
Review of attachment 335939 [details] [review]:

lgtm
Comment 3 Florian Müllner 2016-10-09 16:16:09 UTC 
Attachment 335939 [details] pushed as f2ace41 - room-list: Fix room name alignment