After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771693 - Mount Point column is wider than the screen on openSUSE using btrfs root with lots of mounted subvolumes
Mount Point column is wider than the screen on openSUSE using btrfs root with...
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal minor
: ---
Assigned To: Mike Fleetwood
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2016-09-20 08:21 UTC by Mike Fleetwood
Modified: 2016-10-19 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Display wide Mount Point values better (v1) (11.00 KB, patch)
2016-09-20 18:23 UTC, Mike Fleetwood
none Details | Review

Description Mike Fleetwood 2016-09-20 08:21:03 UTC
This issue was first reported in bug 771323 comment 2 and analysed in
the following comments.

openSUSE 42.1 with default btrfs root installation is heavily using
subvolumes.  (Think of btrfs as a storage pool and subvolumes as
individual file systems within the pool for a rough approximation).
Thus the root partition is mounted on many mount points:

# df -k
Filesystem     1K-blocks    Used Available Use% Mounted on
...
/dev/sda2       19445760 5820080  13157104  31% /
/dev/sda2       19445760 5820080  13157104  31% /var/lib/libvirt/images
/dev/sda2       19445760 5820080  13157104  31% /var/lib/mysql
/dev/sda2       19445760 5820080  13157104  31% /.snapshots
/dev/sda2       19445760 5820080  13157104  31% /home
/dev/sda2       19445760 5820080  13157104  31% /var/opt
/dev/sda2       19445760 5820080  13157104  31% /usr/local
/dev/sda2       19445760 5820080  13157104  31% /var/tmp
/dev/sda2       19445760 5820080  13157104  31% /var/lib/named
/dev/sda2       19445760 5820080  13157104  31% /var/lib/mariadb
/dev/sda2       19445760 5820080  13157104  31% /var/spool
/dev/sda2       19445760 5820080  13157104  31% /var/lib/pgsql
/dev/sda2       19445760 5820080  13157104  31% /var/lib/mailman
/dev/sda2       19445760 5820080  13157104  31% /srv
/dev/sda2       19445760 5820080  13157104  31% /opt
/dev/sda2       19445760 5820080  13157104  31% /var/crash
/dev/sda2       19445760 5820080  13157104  31% /tmp
/dev/sda2       19445760 5820080  13157104  31% /boot/grub2/i386-pc
/dev/sda2       19445760 5820080  13157104  31% /var/log
/dev/sda2       19445760 5820080  13157104  31% /boot/grub2/x86_64-efi

As the Mount Point column contains all 20 mount points it makes the
column wider than the screen, requiring lots of horizontal scrolling to
see the following columns.
Comment 1 Mike Fleetwood 2016-09-20 18:23:36 UTC
Created attachment 335947 [details] [review]
Display wide Mount Point values better (v1)

Hi Curtis,

Here is the patchset for this.  Briefly, it makes the Mount Point column
resizable, narrow and show continuation ellipsis "..." when the data in
column is truncated.  It also wraps the "Mounted on [file system list]"
text shown as the file system status to avoid the Information dialog
also being made too wide.  I don't think that there is anywhere else
which needs correcting.

  (The slight down side with this that modestly wide Mount Point values
  will get ellipsised and spare column width will get added into the
  following expanding columns: Size, Used, Unused and Flags.  I don't
  see any way around this.  Making Mount Point expanding too only gets
  it, its share of the spare width for expansion so probably still won't
  be enough to display modestly wide Mount Point values.

  I kind of would like there to be a priority system for expanding the
  columns of data in the TreeView.  First put spare width into the Mount
  Point column as need to avoid having to ellipsise it.  Second put the
  remaining spare width into expanding the following columns.  There
  doesn't appear to be a standard way to do this with Gtk::TreeView.
  Columns can either be expandable and share spare width or not).

Successfully tested on CentOS 5, CentOS 6, Fedora 24 and openSUSE 42.1.

Thanks,
Mike
Comment 2 Curtis Gedak 2016-10-05 17:11:51 UTC
Hi Mike,

Thank you developing a solution to make the issue of a long mount
point column more aesthetically pleasing.  In my opinion, your
solution is much better than the previous stretched column and
too-wide information dialog.

I tested patch set v1 from comment #1 on openSUSE 13.2 and it worked
flawlessly.  I also confirmed that there were no regressions on
kubuntu 16.04.

As such this patch set has been committed to the git repository for
inclusion in the next release of GParted.

The relevant git commits can be viewed at the following links:

Remove remaining vestiges of coloured text from the partition list
https://git.gnome.org/browse/gparted/commit/?id=85b6858702ccfe654fe0e336afc5d4b675b01107

Show too wide Mount Point column with ellipsis (#771693)
https://git.gnome.org/browse/gparted/commit/?id=1f4f0a4b677eb795ce4d8d8cad6fae5f1c43372c

Line wrap file system status value in the Information dialog (#771693)
https://git.gnome.org/browse/gparted/commit/?id=770ce9a9e1a559250515184dde928ad19937f8d3


Curtis
Comment 3 Curtis Gedak 2016-10-19 16:23:29 UTC
This enhancement was included in the GParted 0.27.0 release on October 19, 2016.