After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771666 - sftp:// property not set for translation in 3.21.92
sftp:// property not set for translation in 3.21.92
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-19 17:38 UTC by Jiri Grönroos
Modified: 2016-09-22 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sftp prefix translation bug (62.42 KB, image/png)
2016-09-20 10:46 UTC, Jiri Grönroos 		  Details
gtkplacesview: mark string as translatable (1.02 KB, patch)
2016-09-22 15:02 UTC, Carlos Soriano 		committed Details | Review

Description Jiri Grönroos 2016-09-19 17:38:42 UTC 
https://git.gnome.org/browse/nautilus/tree/src/gtk/nautilusgtkplacesview.ui?h=3.21.92#n216

<property name="label" comments="Translators: do not translate sftp:// and ssh://">sftp:// or ssh://</property>

This property is missing 'translatable="yes"'
Comment 1 Carlos Soriano 2016-09-20 08:18:20 UTC 
But what you pasted says in the same sentence "Translators: do not translate". Any reason you want to translate those?
Comment 2 Jiri Grönroos 2016-09-20 10:46:17 UTC 
Created attachment 335923 [details]
sftp prefix translation bug
Comment 3 Jiri Grönroos 2016-09-20 10:46:32 UTC 
"or" should be translatable although those prefixes shouldn't be translated.
This would follow the same pattern as with other prefixes, have a look at the attached screenshot.
Comment 4 Carlos Soriano 2016-09-20 14:39:57 UTC 
Indeed, I didn't realize that.
Comment 5 Carlos Soriano 2016-09-22 15:02:24 UTC 
Created attachment 336088 [details] [review]
gtkplacesview: mark string as translatable

We missed it.
Comment 6 Carlos Soriano 2016-09-22 15:03:06 UTC 
Attachment 336088 [details] pushed as cc814fd - gtkplacesview: mark string as translatable