GNOME Bugzilla – Bug 771653
Properties page width is too small
Last modified: 2017-03-03 13:40:15 UTC
Created attachment 335851 [details] Totem properties page. Totem properties page for videos width is too small. Note the attached screenshot. This is likely due to gtk+ 3.21.xx sizing changes?
Created attachment 341339 [details] [review] data: Initial changes made on glade first save
Created attachment 341340 [details] [review] data: GtkVBox to GtkBox
Created attachment 341341 [details] [review] data: Replace packing properties for labels
Created attachment 341342 [details] [review] data: GtkTable to GtkGrid
Created attachment 341343 [details] [review] data: Update padding / width / margin values to decent defaults
The patches work perfectly. Thank you. They also fix the "Audio/Video" property page in nautilus.
Review of attachment 341339 [details] [review]: Pointless, but harmless.
Review of attachment 341340 [details] [review]: Looks good.
Review of attachment 341342 [details] [review]: Looks OK.
Review of attachment 341343 [details] [review]: ::: data/properties.ui @@ +38,3 @@ <property name="visible">True</property> <property name="can_focus">False</property> + <property name="left_padding">20</property> The HIG says to use 18, if I’m interpreting it correctly. https://developer.gnome.org/hig/unstable/visual-layout.html.en
(In reply to Philip Withnall from comment #10) > Review of attachment 341343 [details] [review] [review]: > > ::: data/properties.ui > @@ +38,3 @@ > <property name="visible">True</property> > <property name="can_focus">False</property> > + <property name="left_padding">20</property> > > The HIG says to use 18, if I’m interpreting it correctly. > > https://developer.gnome.org/hig/unstable/visual-layout.html.en That is right. I'm using GtkWidget::margin_start of 12px ( as there is already a 6 px border, which adds to 18px ). Removing deprecated GtkAlignment totally. So, this patch is now replaced by the 3 following patches.
Created attachment 341483 [details] [review] data: Remove deprecated GtkAlignment ( please review no space version diff )
Created attachment 341484 [details] [review] data: Replace GtkAlignment::left_padding with GtkWidget::margin_start
Created attachment 341485 [details] [review] data: Update width_request and margin_bottom values to decent defaults
Created attachment 341715 [details] data: Remove deprecated GtkAlignment ( no space diff for review ) (In reply to vrishab from comment #12) > Created attachment 341483 [details] [review] [review] > data: Remove deprecated GtkAlignment Attaching "no space" version of this patch for easy review. ( Not marking it as patch )
Having tested all the patches together, this seems to work. Thanks!
Attachment 341339 [details] pushed as a8737d6 - data: Initial changes made on glade first save Attachment 341340 [details] pushed as c52d365 - data: GtkVBox to GtkBox Attachment 341341 [details] pushed as ee2f6c1 - data: Replace packing properties for labels Attachment 341342 [details] pushed as c37295a - data: GtkTable to GtkGrid Attachment 341484 [details] pushed as ddbad12 - data: Replace GtkAlignment::left_padding with GtkWidget::margin_start Attachment 341485 [details] pushed as 6631b0d - data: Update width_request and margin_bottom values to decent defaults
*** Bug 778411 has been marked as a duplicate of this bug. ***