GNOME Bugzilla – Bug 771648
subtitle not work when play rate is negative
Last modified: 2018-11-03 11:50:05 UTC
I use playbin to play a out of band subtitle, when I set play rate to -2, the subtitle will disappear and print serveral critical message: (gplay-1.0:1586): GStreamer-CRITICAL **: gst_segment_to_running_time_full: assertion 'stop != -1' failed
By the way, I notice subparse has this piece of code, seems subparse will force its own start/end time. 242 static gboolean 243 gst_sub_parse_src_event (GstPad * pad, GstObject * parent, GstEvent * event) 244 { .... 259 260 gst_event_parse_seek (event, &rate, &format, &flags, 261 &start_type, &start, &stop_type, &stop); 262 .... 268 269 /* Apply the seek to our segment */ 270 gst_segment_do_seek (&self->segment, rate, format, flags, 271 start_type, start, stop_type, stop, &update); 272 273 GST_DEBUG_OBJECT (self, "segment after seek: %" GST_SEGMENT_FORMAT, 274 &self->segment); 275 276 /* Convert that seek to a seeking in bytes at position 0, 277 FIXME: could use an index */ 278 ret = gst_pad_push_event (self->sinkpad, 279 gst_event_new_seek (rate, GST_FORMAT_BYTES, flags, 280 GST_SEEK_TYPE_SET, 0, GST_SEEK_TYPE_NONE, 0)); 281 .... 293 294 beach: 295 return ret; 296 }
Any update?
Created attachment 348970 [details] [review] subparse: fix critical log print out when set rate <0 with external subtitle
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/294.