After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771641 - .desktop is partly untranslated
.desktop is partly untranslated
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-19 03:38 UTC by Piotr Drąg
Modified: 2016-09-29 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Supply more keywords to msgfmt --desktop (1021 bytes, patch)
2016-09-29 07:59 UTC, Daiki Ueno 		committed Details | Review

Description Piotr Drąg 2016-09-19 03:38:56 UTC 
gnome-clocks-3.21.2-1.fc25's .desktop file has translated X-GNOME-FullName and X-Geoclue-Reason fields, while others (Name, GenericName, Keywords etc.) are only in English.
Comment 1 Piotr Drąg 2016-09-27 16:49:23 UTC 
This is pretty bad - the Clocks icon in overview has the English name in every locale.
Comment 2 Paolo Borelli 2016-09-27 17:16:11 UTC 
Sorry... I have no idea how to fix this. Do other packages that dropped intltool have the same problem?
Comment 3 Piotr Drąg 2016-09-27 17:21:52 UTC 
No, they don't. I suspect the code to extract X-Geoclue-Reason and X-GNOME-FullName is to blame, as these are the only translated fields.
Comment 4 Daiki Ueno 2016-09-29 07:55:31 UTC 
Sorry, I forgot the fact that msgfmt ignores the default keywords if any custom keyword is specified.  This could be considered as a bug in msgfmt but will attach a workaround patch.
Comment 5 Daiki Ueno 2016-09-29 07:59:04 UTC 
Created attachment 336485 [details] [review]
build: Supply more keywords to msgfmt --desktop

msgfmt --desktop ignores the default keywords if custom keyword is
specified.  This behavior is inconsistent and should be fixed in msgfmt,
but list those missing keywords to work around the issue.
Comment 6 Paolo Borelli 2016-09-29 09:21:00 UTC 
Review of attachment 336485 [details] [review]:

Thanks Daiki!

I would add a comment like

# msgfmt --desktop ignores the default keywords if custom keywords are
# specified, so we list all the keywords
Comment 7 Daiki Ueno 2016-09-29 13:22:48 UTC 
Attachment 336485 [details] pushed as 27c5b81 - build: Supply more keywords to msgfmt --desktop