GNOME Bugzilla – Bug 771631
Use GtkMessageDialog when appropriate
Last modified: 2017-04-04 07:02:43 UTC
Reading [1] I see buttons in the header bar on the resume/quit dialogs. It's a misunderstanding of the guidelines for using dialog windows [2]. These are simple message dialogs and the buttons should be on the bottom. Use GtkMessageDialog for them, it's still cool! [1] http://bytesgnomeschozo.blogspot.com/2016/09/gnome-games-322-giant-leap.html [2] https://developer.gnome.org/hig/stable/dialogs.html.en
Thanks! Message dialogs indeed look better for this job.
Created attachment 349108 [details] [review] ui: Use Gtk.MessageDialog for resume dialog
Created attachment 349109 [details] [review] ui: Use Gtk.MessageDialog for resume-failed dialog
Created attachment 349110 [details] [review] ui: Use Gtk.MessageDialog for quit dialog
Review of attachment 349110 [details] [review]: LGTM.
Review of attachment 349108 [details] [review]: LGTM.
Review of attachment 349109 [details] [review]: LGTM besides the typo. :) ::: data/ui/resume-failed-dialog.ui @@ +7,3 @@ + <property name="type_hint">dialog</property> + <property name="message_type">question</property> + <property name="text" translatable="yes">Resuming failed. Do you want to to restart the game?</property> Let's take it as an occasion to fix the "to to" typo. :)
Created attachment 349135 [details] Resume dialog The order of the actions feels off to me. What would be the right order?
Created attachment 349136 [details] Quit dialog The cancel action of the right side feels off to me. What would be the right order?
Created attachment 349137 [details] Resume failed dialog The cancel action of the right side feels off to me. What would be the right order?
Attachment 349108 [details] pushed as b2e03a9 - ui: Use Gtk.MessageDialog for resume dialog Attachment 349109 [details] pushed as 2e6d361 - ui: Use Gtk.MessageDialog for resume-failed dialog Attachment 349110 [details] pushed as d1949fa - ui: Use Gtk.MessageDialog for quit dialog
Abhinav: can you check the "Primary buttons" section of https://developer.gnome.org/hig/stable/dialogs.html.en and make sure we follow it correctly? Especially the "don't default to the irreversible actions" part.
Created attachment 349213 [details] [review] ui: Move 'Restart' at the beginning of resume dialog This makes the order of the actions more natural by having 'Restart' first and 'Resume' second.
Created attachment 349214 [details] [review] ui: Move 'Cancel' at the beginning of resume-failed dialog This makes the order of the actions more natural by having 'Cancel' first and 'Reset' second. This also makes 'Cancel' the default action as 'Reset' isn't reversible.
Created attachment 349215 [details] [review] ui: Move 'Cancel' at the beginning of quit dialog This makes the order of the actions more natural by having 'Cancel' first and 'Quit' second.
Attachment 349213 [details] pushed as 82a5099 - ui: Move 'Restart' at the beginning of resume dialog Attachment 349214 [details] pushed as 46d3ae4 - ui: Move 'Cancel' at the beginning of resume-failed dialog Attachment 349215 [details] pushed as f2e6c51 - ui: Move 'Cancel' at the beginning of quit dialog