After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771591 - Update to Unicode 9.0.0
Update to Unicode 9.0.0
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.49.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-09-17 14:02 UTC by Rico Tzschichholz
Modified: 2016-10-05 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unicode: Fix ordering in iso15924_tags to match GUnicodeScript enum (1.18 KB, patch)
2016-10-04 08:42 UTC, Rico Tzschichholz
committed Details | Review

Description Rico Tzschichholz 2016-09-17 14:02:22 UTC
Seems this was forgotten to deal with, so I am hoping it is still possible to merge it.

Patches available at https://git.gnome.org/browse/glib/log/?h=wip/ricotz/unicode-9.0
Comment 1 Matthias Clasen 2016-09-18 11:50:44 UTC
I will leave this to 2.50.1
Comment 2 Christian Persch 2016-09-19 17:50:42 UTC
Just one nit:

+  /* Unicode 9.0 additions */
+  G_UNICODE_SCRIPT_OSAGE,                  /* Osge */
+  G_UNICODE_SCRIPT_NEWA,                   /* Newa */
+  G_UNICODE_SCRIPT_BHAIKSUKI,              /* Bhks */
+  G_UNICODE_SCRIPT_MARCHEN,                /* Marc */
+  G_UNICODE_SCRIPT_TANGUT,                 /* Tang */
+  G_UNICODE_SCRIPT_ADLAM                   /* Adlm */

For previous unicode updates, the newly added scripts were ordered alphabetically (within the added group, of course), so they should be, here, too.
Comment 3 Rico Tzschichholz 2016-09-19 18:26:58 UTC
@chpe: Updated the branch
Comment 4 Rico Tzschichholz 2016-09-21 16:32:32 UTC
commit 1ff79690fbd57a1029918ff37b7890b1096854b6
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Sat Sep 17 15:57:21 2016 +0200

    unicode: Update test data files for unicode 9.0.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771591

commit ba18667bb467ef4734f5d8a9bbeabcad39be4ecc
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Sat Sep 17 15:57:10 2016 +0200

    unicode: Update to unicode 9.0.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771591

commit c7f46997351805e436803ac74a49a88aa1602579
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Sat Sep 17 15:55:48 2016 +0200

    unicode: Update break_mappings
    
    This will be required for the update to unicode 9.0.0.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771591
Comment 5 Christian Persch 2016-10-02 12:02:13 UTC
The unicode test fails now on master. That's because the new scripts were reordered in the enum declaration, but are now out of order in the iso1594_tags table in guniprop.c which means that g_unicode_script_to/from_iso15924 will return incorrect values for those new scripts.
Comment 6 Rico Tzschichholz 2016-10-04 08:42:20 UTC
Created attachment 336858 [details] [review]
unicode: Fix ordering in iso15924_tags to match GUnicodeScript enum
Comment 7 Rico Tzschichholz 2016-10-04 08:43:21 UTC
I am pretty sure I updated them too, I guess a "git add ..." fail :(
Comment 8 Matthias Clasen 2016-10-05 13:18:30 UTC
Review of attachment 336858 [details] [review]:

if it fixes the tests, please push it
Comment 9 Rico Tzschichholz 2016-10-05 13:28:36 UTC
Attachment 336858 [details] pushed as 0d1eecd - unicode: Fix ordering in iso15924_tags to match GUnicodeScript enum