After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771572 - event entry: consider making time button insensitive rather than hiding them altogether
event entry: consider making time button insensitive rather than hiding them ...
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Edit dialog
3.21.x
Other Linux
: Low minor
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-17 04:10 UTC by Mohammed Sadiq
Modified: 2017-08-23 00:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
edit-dialog : correct time row animation (1.26 KB, patch)
2017-08-16 17:13 UTC, Abdullahi Usman 		none Details | Review
[PATCH V2] edit-dialog : correct time row animation (2.62 KB, patch)
2017-08-17 13:50 UTC, Abdullahi Usman 		none Details | Review
[PATCH V3] edit-dialog : correct time row visibility (7.15 KB, patch)
2017-08-22 00:47 UTC, Abdullahi Usman 		none Details | Review
[PATCH V4] edit-dialog : correct time row visibility (7.14 KB, patch)
2017-08-22 00:49 UTC, Abdullahi Usman 		none Details | Review
edit-dialog : correct time row visibility (7.43 KB, patch)
2017-08-23 00:01 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Mohammed Sadiq 2016-09-17 04:10:54 UTC 
In the event entry box, when the user selects 'All day' check button, the Time row is gone hidden. This creates a visual clutter. 

Also, as the hide animation is not completely done (probably the padding between the time row and date row is hidden in a sudden) and no transition animation for revealing, the current animation feels like a flickering to the Event entry window.
Comment 1 Abdullahi Usman 2017-08-16 17:13:03 UTC 
Created attachment 357744 [details] [review]
edit-dialog : correct time row animation
Comment 2 Abdullahi Usman 2017-08-17 13:50:37 UTC 
Created attachment 357812 [details] [review]
[PATCH V2] edit-dialog : correct time row animation
Comment 3 Georges Basile Stavracas Neto 2017-08-19 02:05:03 UTC 
Review of attachment 357812 [details] [review]:

You can just remove the GtkRevealer entirely (and all the hacks to make it work)
Comment 4 Abdullahi Usman 2017-08-22 00:47:01 UTC 
Created attachment 358099 [details] [review]
[PATCH V3] edit-dialog : correct time row visibility
Comment 5 Abdullahi Usman 2017-08-22 00:49:24 UTC 
Created attachment 358100 [details] [review]
[PATCH V4] edit-dialog : correct time row visibility
Comment 6 Georges Basile Stavracas Neto 2017-08-23 00:00:24 UTC 
Review of attachment 358100 [details] [review]:

The time selector widgets should bind the 'sensitive' property with the 'writable' property of GcalEditDialog
Comment 7 Georges Basile Stavracas Neto 2017-08-23 00:01:50 UTC 
Created attachment 358186 [details] [review]
edit-dialog : correct time row visibility

Fix the sensitivity property.
Comment 8 Georges Basile Stavracas Neto 2017-08-23 00:02:35 UTC 
Thanks for the patch!

Attachment 358186 [details] pushed as e56bbc7 - edit-dialog : correct time row visibility