After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771566 - Calendar entry added twice If an event is added to non default calendar
Calendar entry added twice If an event is added to non default calendar
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.21.x
Other Linux
: Normal major
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
: 774948 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-17 02:53 UTC by Mohammed Sadiq
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
edit-dialog: check if event is new the right way (1.36 KB, patch)
2016-11-22 07:29 UTC, Mohammed Sadiq
committed Details | Review

Description Mohammed Sadiq 2016-09-17 02:53:50 UTC
When I add an event to a calendar with non-English name, the event is added twice. One to the default Calendar, and one the current selected one.

How to reproduce:
1. Add some calendar with non-English name.
   eg: നല്ലത്
2. Now Add Some event: In month view click on some cell -> Click 'Edit Details'
3. Select the newly added calendar from the list.
4. Give some name -> click 'Done'

Result:
The event is added twice. One to the default calendar, and other to the Selected calendar.

Expected result:
The event should be added only once, and to the selected calendar.
Comment 1 Marinus Schraal 2016-09-23 12:37:28 UTC
This is just the same for english calendars. So you can remove step 1.
Comment 2 Mohammed Sadiq 2016-09-23 13:45:41 UTC
(In reply to Marinus Schraal from comment #1)
> This is just the same for english calendars. So you can remove step 1.

Hm.. Yeah. Thanks for pointing that out.
Comment 3 Mohammed Sadiq 2016-11-22 07:29:22 UTC
Created attachment 340489 [details] [review]
edit-dialog: check if event is new the right way

Checking if a new event is already having a source succeeds
for some reason (which should actually fail).

But thankfully we already have an event_is_new gboolean flag.
Check the status of that flag and add or update the event.
Comment 4 Georges Basile Stavracas Neto 2016-11-22 11:55:02 UTC
Thanks for the patch!

Attachment 340489 [details] pushed as 6cf5c03 - edit-dialog: check if event is new the right way
Comment 5 Mohammed Sadiq 2017-02-02 14:07:11 UTC
*** Bug 774948 has been marked as a duplicate of this bug. ***