GNOME Bugzilla – Bug 771549
Reversing the UI for RTL no longer works in gnome shell
Last modified: 2016-09-19 21:27:05 UTC
This is caused by the fact that clutter_get_default_text_direction returns CLUTTER_TEXT_DIRECTION_LTR, because the translations have been removed from the copy of clutter embedded in mutter. https://git.gnome.org/browse/mutter/tree/clutter/clutter/clutter-main.c#n706 https://git.gnome.org/browse/mutter/commit/?id=a4fb7ef5a3e8902a9ea45040df475735c862fcb0
Created attachment 335728 [details] [review] clutter: Reuse GTK+'s RTL/LTR handling Commit a4fb7ef5a3e dropped translations of our internal cogl/clutter forks, which broke the local-based text direction support. Instead of bringing back translations just for this purpose, we can re-use GTK's translations which use the same technique. Only compile-tested on my part, so some proper testing would be appreciated.
(In reply to Florian Müllner from comment #1) > Only compile-tested on my part, so some proper testing would be appreciated. Tested now with he_IL.utf8, everything looks right (to left) to me ...
Yes, it's working fine. Thanks :-)
Review of attachment 335728 [details] [review]: oops, looks good
Review of attachment 335728 [details] [review]: ::: clutter/clutter/clutter-main.c @@ +721,3 @@ { + /* Re-use GTK+'s LTR/RTL handling */ + const char *e = g_dgettext("gtk30", "default:LTR"); Missing space before opening parenthesis
(In reply to Michael Catanzaro from comment #5) > Missing space before opening parenthesis Gah, fixed locally.
Attachment 335728 [details] pushed as a4e69f3 - clutter: Reuse GTK+'s RTL/LTR handling