After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771513 - ui: Media selector sometimes visible on 'Unable to run game' page
ui: Media selector sometimes visible on 'Unable to run game' page
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-16 07:16 UTC by Adrien Plazas
Modified: 2016-09-16 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ui: Hide the media selector button by default (1012 bytes, patch)
2016-09-16 08:18 UTC, Adrien Plazas
committed Details | Review
ui: Reset the display UI state before getting the runner (1.21 KB, patch)
2016-09-16 08:18 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2016-09-16 07:16:11 UTC
The media selector button is visible on the 'Unable to run game' page if it hasn't been hidden before: either by entering this page first or after running a game displaying a media selector.
Comment 1 Adrien Plazas 2016-09-16 08:18:19 UTC
Created attachment 335681 [details] [review]
ui: Hide the media selector button by default

This fixes its default behavior which should be to be hidden as by
default games don't let the player chose beteen multiple medias.
Comment 2 Adrien Plazas 2016-09-16 08:18:27 UTC
Created attachment 335682 [details] [review]
ui: Reset the display UI state before getting the runner

This avoids the display part of the UI to be in an inconsistent state if
we couldn't get the game's runner.
Comment 3 Adrien Plazas 2016-09-16 08:24:51 UTC
Attachment 335681 [details] pushed as 2157799 - ui: Hide the media selector button by default
Attachment 335682 [details] pushed as aeec625 - ui: Reset the display UI state before getting the runner