After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771512 - grilo: Critical errors caused by wrong 'return_if_fail'
grilo: Critical errors caused by wrong 'return_if_fail'
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-16 06:56 UTC by Adrien Plazas
Modified: 2016-09-16 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grilo: Replace some return_if_fail by normal tests (1.10 KB, patch)
2016-09-16 08:17 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-09-16 06:56:32 UTC 
In GriloCover.on_media_resolved() some return_if_fail() are used for normal cases where a simple test+return should be used, causing some wrong critical errors.
Comment 1 Adrien Plazas 2016-09-16 08:17:20 UTC 
Created attachment 335680 [details] [review]
grilo: Replace some return_if_fail by normal tests

Replace some return_if_fail tests by normal tests which can return in
GriloCover.on_media_resolved().

This avoids wrong critical errors.
Comment 2 Adrien Plazas 2016-09-16 08:24:33 UTC 
Attachment 335680 [details] pushed as 921b1d9 - grilo: Replace some return_if_fail by normal tests