GNOME Bugzilla – Bug 771510
seed: fix make distcheck
Last modified: 2016-09-16 12:57:27 UTC
This library is currently in a pretty pitiful state, I'm only doing basic sanitization here. Two things I have not addressed, because they will certainly imply way more work: Actually fixing the tests; running make check failed in the first of the test subdirectories, once I marked a few tests as known to fail other tests appeared, and unsurprisingly did not pass, the final result is 11 tests failing out of 60, at least we're now aware of these failures :) seed currently requires being installed both for the tests to fail as expected and for make fistcheck to pass (these two issues are linked). This should be fixed at some point, but my priority was to have make distcheck pass, which is the case with this set of patches.
Created attachment 335667 [details] [review] make check: mark known-to-fail tests with XFAIL_TESTS. Without this, make check stopped recursing up at the first subdirectory failure, in our case in tests/javascript/gtypes, leading to: * The incorrect impression that the test suite consisted of only 12 tests. * Making it impossible for make distcheck to pass. * First-time users wasting time figuring out what in their environment was responsible for these failures, as one usually expects make check to pass. See https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html
Created attachment 335668 [details] [review] jsextensions: sanitize and make make distcheck pass .. in that directory, there are other errors in other places.
Created attachment 335669 [details] [review] doc: fix make distcheck
Created attachment 335670 [details] [review] Fix tests when builddir != srcdir
Created attachment 335671 [details] [review] Delete old .gitignore And use git.mk instead
Created attachment 335672 [details] [review] Uninstall documentation correctly
Created attachment 335673 [details] [review] doc/modules: gtk-doc must be run in the html subfolder. gtkdoc-mkhtml will output html.stamp in the parent folder, and it never got cleaned afterwards. Not sure why doc/modules does not use the gtk-doc makefile fragment, but I'm not going for the best solution, simply the one that does not break distcheck by leaving build artefacts in random places.
Created attachment 335674 [details] [review] Fix tests when builddir != srcdir
Attachment 335667 [details] pushed as 6e115d2 - make check: mark known-to-fail tests with XFAIL_TESTS. Attachment 335668 [details] pushed as 7105800 - jsextensions: sanitize and make make distcheck pass Attachment 335669 [details] pushed as 7daa813 - doc: fix make distcheck Attachment 335671 [details] pushed as 6651630 - Delete old .gitignore Attachment 335672 [details] pushed as ec7aaf7 - Uninstall documentation correctly Attachment 335673 [details] pushed as 7a70f39 - doc/modules: gtk-doc must be run in the html subfolder. Attachment 335674 [details] pushed as 369fda3 - Fix tests when builddir != srcdir