After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771502 - gnome-screenshot area does not work when paired with current GNOME 3.21.92
gnome-screenshot area does not work when paired with current GNOME 3.21.92
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 772878 772999 773080 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-09-15 18:57 UTC by Bjørn Lie
Modified: 2016-10-17 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clutter/stage: Fix framebuffer capture origin offset (1.23 KB, patch)
2016-09-19 15:26 UTC, Rui Matos
committed Details | Review
clutter/stage: Fix framebuffer capture origin offset (again) (1.38 KB, patch)
2016-09-21 13:12 UTC, Rui Matos
committed Details | Review

Description Bjørn Lie 2016-09-15 18:57:33 UTC
The geometry of gnome-screenshot --area is currently "broken" for me in both X and wayland.

Fullscreen and window are working fine, it's just when one select a small area the bug shows, depending on how "large" an area one selects, either rendering a blank image or the wrong cordinates.
Comment 1 Hussam Al-Tayeb 2016-09-19 13:19:36 UTC
Same issue with Gimp. So it is not specific to gnome-screenshot.
Comment 2 Cosimo Cecchi 2016-09-19 15:07:04 UTC
-> gnome-shell

Most likely this is a problem with gnome-shell then.
Comment 3 Rui Matos 2016-09-19 15:26:55 UTC
Created attachment 335869 [details] [review]
clutter/stage: Fix framebuffer capture origin offset

Commit f36fa53b0e8b7e2389ea2b63516a2eb00fcc7aa5 had the offset math
wrong and the reviewer didn't notice it.
Comment 4 Florian Müllner 2016-09-19 15:32:03 UTC
Review of attachment 335869 [details] [review]:

Eeeks, yes
Comment 5 André Klapper 2016-09-19 16:58:26 UTC
Wondering if this might also influence/fix bug 771192?
Comment 6 Rui Matos 2016-09-19 20:36:48 UTC
(In reply to André Klapper from comment #5)
> Wondering if this might also influence/fix bug 771192?

I don't think so, that bug actually reproduces without taking screenshots and as I said there, it seems to be a chrome issue.
Comment 7 Rui Matos 2016-09-19 20:41:24 UTC
Pushing with RT approval for freeze break.

Attachment 335869 [details] pushed as 5fbb479 - clutter/stage: Fix framebuffer capture origin offset
Comment 8 Dominique Leuenberger 2016-09-21 10:08:08 UTC
something must be incomplete / still wrong (or different wrong)

I have a dual-screen setup (notebook, internal lcd plus connected monitor)

It is not possible to select an area for screenshots on 'the left monitor' (not related to primary it seems)

Taking a screenshot on 'the left monitor' gives an al transparent image.

I intentionally write 'left monitor' as I changed the layout of the screens, moving the 2nd screen to be left of 1st (primary) screen - then the effect moves to that screen. Inverting the layout again, making primary left of secondary moves the effect back.
Comment 9 Rui Matos 2016-09-21 13:12:50 UTC
Created attachment 335993 [details] [review]
clutter/stage: Fix framebuffer capture origin offset (again)

Commit 5fbb4793017b1891f0de4720a9793e8cfc1c8483 was wrong too. What we
really want to do here is getting view relative coordinates given the
view's and the rectangle's global coordinates so we need to subtract
the view's origin from the rectangle's.

--

Thanks for reporting, I misunderstood the kind of coordinates needed
in cogl_framebuffer_read_pixels_into_bitmap() .
Comment 10 Dominique Leuenberger 2016-09-21 13:34:47 UTC
Thanks Rui,

I gave that patch a very quick spin - I can now select regions to screenshot on both my screens
Comment 11 Florian Müllner 2016-10-14 15:41:28 UTC
Review of attachment 335993 [details] [review]:

OK
Comment 12 Florian Müllner 2016-10-14 15:42:35 UTC
*** Bug 772878 has been marked as a duplicate of this bug. ***
Comment 13 Jonas Ådahl 2016-10-15 07:38:22 UTC
Review of attachment 335993 [details] [review]:

I didn't notice this patch, and fixed it locally myself, and I got the exact same diff.
Comment 14 Florian Müllner 2016-10-15 20:55:33 UTC
*** Bug 772999 has been marked as a duplicate of this bug. ***
Comment 15 Florian Müllner 2016-10-17 11:44:58 UTC
*** Bug 773080 has been marked as a duplicate of this bug. ***
Comment 16 Rui Matos 2016-10-17 12:00:06 UTC
Attachment 335993 [details] pushed as fc8de3d - clutter/stage: Fix framebuffer capture origin offset (again)
Comment 17 Laurent Bigonville 2016-10-17 13:33:50 UTC
Thanks, are you planning to make a new release with this fix included?
Comment 18 André Klapper 2016-10-17 13:57:14 UTC
@Laurent:
The fix was backported to the 3.22 branch in https://git.gnome.org/browse/mutter/commit/?h=gnome-3-22&id=5ec5e294226ef8ef47af1b56b4c0c349aea7d607 hence the 3.22.2 release will include the fix: https://wiki.gnome.org/ThreePointTwentythree