After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771490 - batch rename: system freezes as nautilus takes too much CPU and memory
batch rename: system freezes as nautilus takes too much CPU and memory
Status: RESOLVED DUPLICATE of bug 772434
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.21.x
Other Linux
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-15 13:50 UTC by Mohammed Sadiq
Modified: 2016-10-11 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
batch-rename: Fix memory leaks (4.30 KB, patch)
2016-09-29 19:09 UTC, Alexandru Pandelea
accepted-commit_now Details | Review

Description Mohammed Sadiq 2016-09-15 13:50:45 UTC
In some occasions Nautilus takes too much memory and CPU on batch rename Freezing the complete system. I had to force reboot my system after this. You have been warned, test with caution :).

How to reproduce:

1. Create several files.
   touch {0000..9999}
2. Select all files -> Rename.
3. Remove '[Original file name]' and add '[001, 002, 003]' (other numeri counters may also do the same)

Result:
Nautilus usage of memory increases with time, eating every available piece of memory.
Comment 1 Alexandru Pandelea 2016-09-29 19:09:43 UTC
Created attachment 336539 [details] [review]
batch-rename: Fix memory leaks

Fix memory leaks for batch renaming.
Comment 2 Carlos Soriano 2016-09-30 08:09:19 UTC
Review of attachment 336539 [details] [review]:

Hey Alex, looks good, thanks! 
How did you catch them? Valgrind?
In case it was without it, would be good to run valgrind to catch all the memory leaks we could have in there :)
Comment 3 Carlos Soriano 2016-10-11 18:22:01 UTC

*** This bug has been marked as a duplicate of bug 772434 ***