After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771483 - Remove some redundant code
Remove some redundant code
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: smb backend
1.29.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2016-09-15 10:38 UTC by Ondrej Holy
Modified: 2016-10-03 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
smb: Remove some redundant code (1.49 KB, patch)
2016-09-15 10:40 UTC, Ondrej Holy 		committed Details | Review
smb: Remove redundant cache functionality (4.76 KB, patch)
2016-09-15 10:40 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2016-09-15 10:38:56 UTC 
There is some redundant code in smb backend which can be removed, see the following patches...
Comment 1 Ondrej Holy 2016-09-15 10:40:11 UTC 
Created attachment 335619 [details] [review]
smb: Remove some redundant code

Remove some ancient comments, dead code, or duplicated code.
Comment 2 Ondrej Holy 2016-09-15 10:40:58 UTC 
Created attachment 335620 [details] [review]
smb: Remove redundant cache functionality

I'm convinced that our own server cache is not needed, because we are not using it in no way. Let's remove the cache and let samba use its internal cache instead:
https://git.samba.org/cifs-utils.git/?p=samba.git;a=blob;f=source3/libsmb/libsmb_cache.c
Comment 3 Tomas Bzatek 2016-10-03 12:51:22 UTC 
Review of attachment 335619 [details] [review]:

I take the blame for adding these comments so yes, feel free to remove them :-)
Comment 4 Tomas Bzatek 2016-10-03 12:55:26 UTC 
Review of attachment 335620 [details] [review]:

Right, this seems to be more important in smbbrowse than here and I don't really remember why it was ever here.
Comment 5 Ondrej Holy 2016-10-03 14:47:55 UTC 
Thanks for your reviews! Can we look forward to your return in GVfs upstream?
Comment 6 Ondrej Holy 2016-10-03 14:48:40 UTC 
Attachment 335619 [details] pushed as daeed46 - smb: Remove some redundant code
Attachment 335620 [details] pushed as bc4ade5 - smb: Remove redundant cache functionality