After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771455 - tests: use dbus-run-session instead of dbus-launch to run tests
tests: use dbus-run-session instead of dbus-launch to run tests
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
0.33.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-15 01:37 UTC by Michael Biebl
Modified: 2017-04-26 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Use dbus-run-session instead of dbus-launch (1.39 KB, patch)
2016-09-15 01:41 UTC, Michael Biebl
committed Details | Review

Description Michael Biebl 2016-09-15 01:37:51 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836067

dbus-launch is X11-specific and contains a lot of legacy code to
support X11 autolaunching. It should not be part of the Wayland
(and/or Mir) future.

Use dbus-run-session to run the tests instead.
Comment 1 Michael Biebl 2016-09-15 01:41:27 UTC
Created attachment 335599 [details] [review]
tests: Use dbus-run-session instead of dbus-launch
Comment 2 Rico Tzschichholz 2016-09-16 16:58:01 UTC
Could you make it conditional depending on presence of required executable, otherwise this would be an implicit bump to dbus >= 1.8?
Comment 3 Michael Biebl 2016-09-16 17:27:00 UTC
Correct, this requires dbus >= 1.8. Is that an issue?
dbus 1.8.0 was released 2014-01-20, i.e. over 2,5 years ago.
Comment 4 Rico Tzschichholz 2016-09-16 17:47:43 UTC
I want to keep it buildable without any hassle on Ubuntu Trusty 14.04 which comes with dbus 1.6.18.
Comment 5 Michael Biebl 2016-10-12 23:01:55 UTC
The package would be buildable on trusty. You'd just have to skip running the test-suite.
I'd rather not make testrunner.sh more complicated then necessary.
Comment 6 Rico Tzschichholz 2017-04-26 20:53:39 UTC
Comment on attachment 335599 [details] [review]
tests: Use dbus-run-session instead of dbus-launch

commit ef50a4259393c64c6beb36dd96e60d185da22fdd
Author: Michael Biebl <mbiebl@gmail.com>
Date:   Thu Sep 15 03:41:00 2016 +0200

    tests: Use dbus-run-session instead of dbus-launch
    
    dbus-launch is X11-specific and contains a lot of legacy code to
    support X11 autolaunching. It should not be part of the Wayland
    future.
    
    Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836067